Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [FC-0070] Manage Tags interoperation #1454

Draft
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

PKulkoRaccoonGang
Copy link
Contributor

Description

Manage Tags interoperation between MFE and Studio xBlock View

Useful information to include:

  • Which edX user roles will this change impact? Common user roles are "Learner", "Course Author",
    "Developer", and "Operator".
  • Include screenshots for changes to the UI (ideally, both "before" and "after" screenshots, if applicable).
  • Provide links to the description of corresponding configuration changes. Remember to correctly annotate these
    changes.

Supporting information

Link to other information about the change, such as Jira issues, GitHub issues, or Discourse discussions.
Be sure to check they are publicly readable, or if not, repeat the information here.

Testing instructions

Please provide detailed step-by-step instructions for testing this change.

Other information

Include anything else that will help reviewers and consumers understand the change.

  • Does this change depend on other changes elsewhere?
  • Any special concerns or limitations? For example: deprecations, migrations, security, or accessibility.

@PKulkoRaccoonGang PKulkoRaccoonGang requested a review from a team as a code owner October 31, 2024 19:14
@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Oct 31, 2024
@openedx-webhooks
Copy link

openedx-webhooks commented Oct 31, 2024

Thanks for the pull request, @PKulkoRaccoonGang!

What's next?

Please work through the following steps to get your changes ready for engineering review:

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Update the status of your PR

Your PR is currently marked as a draft. After completing the steps above, update its status by clicking "Ready for Review", or removing "WIP" from the title, as appropriate.

🔘 Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @openedx/2u-tnl. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@PKulkoRaccoonGang PKulkoRaccoonGang marked this pull request as draft October 31, 2024 19:14
@PKulkoRaccoonGang PKulkoRaccoonGang self-assigned this Oct 31, 2024
Copy link

codecov bot commented Nov 4, 2024

Codecov Report

Attention: Patch coverage is 75.11111% with 112 lines in your changes missing coverage. Please review.

Project coverage is 92.73%. Comparing base (3d8d248) to head (3e33967).
Report is 11 commits behind head on master.

Files with missing lines Patch % Lines
src/course-unit/move-modal/hooks.tsx 70.96% 27 Missing ⚠️
src/course-unit/xblock-container-iframe/index.tsx 72.41% 24 Missing ⚠️
src/course-unit/data/thunk.js 26.08% 15 Missing and 2 partials ⚠️
src/course-unit/move-modal/index.tsx 76.00% 12 Missing ⚠️
src/course-unit/CourseUnit.jsx 10.00% 8 Missing and 1 partial ⚠️
src/course-unit/hooks.jsx 52.63% 9 Missing ⚠️
src/course-unit/context/iFrameContext.tsx 46.15% 7 Missing ⚠️
src/content-tags-drawer/ContentTagsDrawer.tsx 83.33% 2 Missing ⚠️
src/course-unit/data/api.js 60.00% 2 Missing ⚠️
src/course-unit/context/hooks.tsx 85.71% 1 Missing ⚠️
... and 2 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1454      +/-   ##
==========================================
- Coverage   93.16%   92.73%   -0.44%     
==========================================
  Files        1054     1059       +5     
  Lines       20467    20815     +348     
  Branches     4285     4375      +90     
==========================================
+ Hits        19068    19302     +234     
- Misses       1339     1450     +111     
- Partials       60       63       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mphilbrick211 mphilbrick211 added the FC Relates to an Axim Funded Contribution project label Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FC Relates to an Axim Funded Contribution project open-source-contribution PR author is not from Axim or 2U
Projects
Status: Waiting on Author
Development

Successfully merging this pull request may close these issues.

4 participants