-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: enable problem bank button functionality #1480
base: master
Are you sure you want to change the base?
Conversation
Thanks for the pull request, @navinkarkera! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Update the status of your PRYour PR is currently marked as a draft. After completing the steps above, update its status by clicking "Ready for Review", or removing "WIP" from the title, as appropriate. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently maintained by Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1480 +/- ##
==========================================
- Coverage 93.28% 93.27% -0.02%
==========================================
Files 1052 1053 +1
Lines 20503 20512 +9
Branches 4385 4387 +2
==========================================
+ Hits 19126 19132 +6
- Misses 1317 1320 +3
Partials 60 60 ☔ View full report in Codecov by Sentry. |
dee4195
to
72b503f
Compare
Also, updates library v2 and problem bank icons and adds a beta tag based on api response.
72b503f
to
f8e00da
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Thank you for your work, @navinkarkera!
- I tested this using the instructions from the PR
- I read through the code
- I checked for accessibility issues
- Includes documentation
<div | ||
key={componentTemplate.displayName} | ||
className="d-flex justify-content-between w-100 mb-2.5 align-items-end" | ||
> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch!
Description
Implements: #1462
Also, updates library v2 and problem bank icons and adds a beta tag based on api response.
Supporting information
Private-ref
: FAL-3936Testing instructions
Problem Bank
option is working (adding a problem block). Verify the icons and beta badge forProblem Bank
andLibrary content
buttons.