-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Show published count component in library content picker [FC-0062] #1481
base: master
Are you sure you want to change the base?
fix: Show published count component in library content picker [FC-0062] #1481
Conversation
Thanks for the pull request, @ChrisChV! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently maintained by Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1481 +/- ##
=======================================
Coverage 93.27% 93.28%
=======================================
Files 1052 1052
Lines 20496 20506 +10
Branches 4393 4388 -5
=======================================
+ Hits 19118 19129 +11
+ Misses 1315 1314 -1
Partials 63 63 ☔ View full report in Codecov by Sentry. |
[retracted] -- my bad, I wasn't running the right branch. 😊 |
@ChrisChV [retracted] -- my bad, this is not a problem, I wasn't running the right branch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Works great, thank you @ChrisChV !
Apologies for the noise in my previous comments :)
- I tested this using my tutor dev stack and the PR test instructions.
- I read through the code
-
I checked for accessibility issuesN/A -
Includes documentationN/A -
User-facing strings are extracted for translationN/A
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Works beautifully, thanks @ChrisChV !
- I tested this using the PR test instructions
- I read through the code
-
I checked for accessibility issuesN/A -
Includes documentationN/A -
User-facing strings are extracted for translationN/A
Description
When using the library component picker, show the correct number on component count (published components) in collection cards.
Supporting information
Github issue: openedx/modular-learning#234
Internal ticket: FAL-3921
Depends on: openedx/edx-platform#35734
Testing instructions