Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Show published count component in library content picker [FC-0062] #1481

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ChrisChV
Copy link
Contributor

@ChrisChV ChrisChV commented Nov 7, 2024

Description

When using the library component picker, show the correct number on component count (published components) in collection cards.

  • Which edX user roles will this change impact? "Course Author"

Supporting information

Github issue: openedx/modular-learning#234
Internal ticket: FAL-3921
Depends on: openedx/edx-platform#35734

Testing instructions

  • Use this branch of edx-paltform: fix: Keep sync component count in collection card [FC-0062] edx-platform#35734
  • Go library home page of a library
  • Create or use a collection
  • Create components in the collection
  • Publish the library
  • Create new components, but not publish the library
  • Go to a unit in a course and add a "Library content", using the legacy UI
  • Select your library and search your collection
  • Check that in the collection card, the component count shows only the published components

@ChrisChV ChrisChV requested a review from a team as a code owner November 7, 2024 15:32
@openedx-webhooks
Copy link

Thanks for the pull request, @ChrisChV!

What's next?

Please work through the following steps to get your changes ready for engineering review:

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @openedx/2u-tnl. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Nov 7, 2024
@ChrisChV ChrisChV changed the title fix: Show published count component in library content picker fix: Show published count component in library content picker [FC-0062] Nov 7, 2024
Copy link

codecov bot commented Nov 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.28%. Comparing base (fc94667) to head (33492d7).
Report is 4 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1481   +/-   ##
=======================================
  Coverage   93.27%   93.28%           
=======================================
  Files        1052     1052           
  Lines       20496    20506   +10     
  Branches     4393     4388    -5     
=======================================
+ Hits        19118    19129   +11     
+ Misses       1315     1314    -1     
  Partials       63       63           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pomegranited
Copy link
Contributor

pomegranited commented Nov 8, 2024

[retracted] -- my bad, I wasn't running the right branch. 😊

@pomegranited
Copy link
Contributor

pomegranited commented Nov 8, 2024

@ChrisChV [retracted] -- my bad, this is not a problem, I wasn't running the right branch.

Copy link
Contributor

@pomegranited pomegranited left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Works great, thank you @ChrisChV !

Apologies for the noise in my previous comments :)

  • I tested this using my tutor dev stack and the PR test instructions.
  • I read through the code
  • I checked for accessibility issues N/A
  • Includes documentation N/A
  • User-facing strings are extracted for translation N/A

Copy link
Contributor

@pomegranited pomegranited left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Works beautifully, thanks @ChrisChV !

  • I tested this using the PR test instructions
  • I read through the code
  • I checked for accessibility issues N/A
  • Includes documentation N/A
  • User-facing strings are extracted for translation N/A

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants