-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: fixed height for prerequisite course dropdown list #1555
base: open-release/redwood.master
Are you sure you want to change the base?
feat: fixed height for prerequisite course dropdown list #1555
Conversation
Thanks for the pull request, @ihor-romaniuk! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## open-release/redwood.master #1555 +/- ##
==============================================================
Coverage ? 92.34%
==============================================================
Files ? 708
Lines ? 12564
Branches ? 2702
==============================================================
Hits ? 11602
Misses ? 925
Partials ? 37 ☔ View full report in Codecov by Sentry. |
Backport: #1154 (original PR to master)
Related PR: #1554 (backport to quince branch)
Description
made fixed height for the prerequisite course dropdown list.
Note: same height is set for the course language dropdown list.
Steps to reproduce
contentstore.new_studio_mfe.use_new_grading_page
(in /admin/waffle/flag);studio -> Settings -> Schedule & details
;BEFORE
Drop-down list goes beyond footer
![1](https://private-user-images.githubusercontent.com/17108583/393759153-67f54f05-6521-434f-9cc4-32009e1f8dff.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkwMjkzODAsIm5iZiI6MTczOTAyOTA4MCwicGF0aCI6Ii8xNzEwODU4My8zOTM3NTkxNTMtNjdmNTRmMDUtNjUyMS00MzRmLTljYzQtMzIwMDllMWY4ZGZmLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMDglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjA4VDE1MzgwMFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTRkOWNhNjY4NThjZDQyMzY5YTYzMWQ2MDRjNGViZmQzMTdhYTM4NDM3NTFhZWM1MjA5M2QzMDkzM2ZmMjExYTcmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.W8MMFjOWKQvoUzP8tPUzyQnOlp7kqtCQ0WilLdBS_PA)
AFTER
Drop-down list has the same height as Course language
![2](https://private-user-images.githubusercontent.com/17108583/393759188-d8076c02-2415-4ed2-a4a2-7e6c86a99b93.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkwMjkzODAsIm5iZiI6MTczOTAyOTA4MCwicGF0aCI6Ii8xNzEwODU4My8zOTM3NTkxODgtZDgwNzZjMDItMjQxNS00ZWQyLWE0YTItN2U2Yzg2YTk5YjkzLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMDglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjA4VDE1MzgwMFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTQ1OTc4ZjhlNjU1OGU5ZmMyY2E2ZjlhOGVhNTFiNjJkNTk4Nzg4YmE3ODc4NzY2MzIyODc3NjVmZmE0OTMxMWEmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.FnPsfP7HHZX74QcscqTG1DZX2gGZNQTrTmmfZZBReR4)
![3](https://private-user-images.githubusercontent.com/17108583/393759256-db92b368-0a39-42b8-8b85-0b7a86d2b23c.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkwMjkzODAsIm5iZiI6MTczOTAyOTA4MCwicGF0aCI6Ii8xNzEwODU4My8zOTM3NTkyNTYtZGI5MmIzNjgtMGEzOS00MmI4LThiODUtMGI3YTg2ZDJiMjNjLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMDglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjA4VDE1MzgwMFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPThhMTQwNDE5OThmY2UwOWI1M2ZhOGU5ZGRjNzEzNzJjNWNiY2YyMmM1OWNmMDcwM2RmMjBhNDA3NWNmYWVhNTQmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.wBEaSY8r6JrD42gxEw5Jh6UZyyUHeYQEzKu-vLh-6og)
Course language example