Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change ComponentPreview modal size to xl [FC-0076] #1650

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rpenido
Copy link
Contributor

@rpenido rpenido commented Feb 5, 2025

Description

This PR changes the PreviewComponent modal size from the default "md" to "xl".

Preview

image

After

image

Supporting information

Related to #1343

Testing instructions

Open the component preview modal using the "Expand" button on the component sidebar and check the width before and after this PR.

Settings

TUTOR_GROVE_ADDITIONAL_DOMAINS:
 - domain: meilisearch.{{ LMS_HOST }}

Private ref: FAL-3991

@openedx-webhooks
Copy link

openedx-webhooks commented Feb 5, 2025

Thanks for the pull request, @rpenido!

This repository is currently maintained by @openedx/2u-tnl.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.


Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Feb 5, 2025
@rpenido rpenido changed the title fix: change ComponentPreview modal size to xl fix: change ComponentPreview modal size to xl [FC-0076] Feb 5, 2025
Copy link

codecov bot commented Feb 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.24%. Comparing base (05dddce) to head (cffca66).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1650   +/-   ##
=======================================
  Coverage   93.24%   93.24%           
=======================================
  Files        1101     1101           
  Lines       21859    21859           
  Branches     4643     4644    +1     
=======================================
  Hits        20383    20383           
  Misses       1411     1411           
  Partials       65       65           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@pomegranited pomegranited left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 I think making the preview modal bigger is a fine idea overall, and it's a nice side-effect that it lets us preview survey block in a size that's more like what students will see.

Might want to run this past Product before it merges though, just in case -- either with a movie or a sandbox.

  • I tested this on my tutor dev stack by previewing a library survey block.
  • I read through the code
  • I checked for accessibility issues by using my keyboard to navigate
  • Includes documentation N/A
  • User-facing strings are extracted for translation N/A

@pomegranited pomegranited added the create-sandbox open-craft-grove should create a sandbox environment from this PR label Feb 6, 2025
@open-craft-grove
Copy link

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

@open-craft-grove
Copy link

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

@rpenido
Copy link
Contributor Author

rpenido commented Feb 11, 2025

Hi! CC @jmakowski1123 @lizc577 @sdaitzman @marcotuts
I propose changing the default size of the component's preview modal for library authoring so that it shows a better view of the rendered component.
Could you give me your thoughts on it?

You can check it on the sandbox.
i.e. https://app.tagging-preview.staging.do.opencraft.hosting/authoring/library/lib:SampleTaxonomyOrg1:ACTESTING/components

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
create-sandbox open-craft-grove should create a sandbox environment from this PR open-source-contribution PR author is not from Axim or 2U
Projects
Status: Waiting on Author
Development

Successfully merging this pull request may close these issues.

4 participants