-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: change ComponentPreview modal size to xl [FC-0076] #1650
base: master
Are you sure you want to change the base?
fix: change ComponentPreview modal size to xl [FC-0076] #1650
Conversation
Thanks for the pull request, @rpenido! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1650 +/- ##
=======================================
Coverage 93.24% 93.24%
=======================================
Files 1101 1101
Lines 21859 21859
Branches 4643 4644 +1
=======================================
Hits 20383 20383
Misses 1411 1411
Partials 65 65 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 I think making the preview modal bigger is a fine idea overall, and it's a nice side-effect that it lets us preview survey block in a size that's more like what students will see.
Might want to run this past Product before it merges though, just in case -- either with a movie or a sandbox.
- I tested this on my tutor dev stack by previewing a library survey block.
- I read through the code
- I checked for accessibility issues by using my keyboard to navigate
-
Includes documentationN/A -
User-facing strings are extracted for translationN/A
Sandbox deployment successful 🚀 |
Sandbox deployment successful 🚀 |
Hi! CC @jmakowski1123 @lizc577 @sdaitzman @marcotuts You can check it on the sandbox. |
Description
This PR changes the
PreviewComponent
modal size from the default"md"
to"xl"
.Preview
After
Supporting information
Related to #1343
Testing instructions
Open the component preview modal using the "Expand" button on the component sidebar and check the width before and after this PR.
Settings
Private ref: FAL-3991