Skip to content

feat: Fixed delete for additional video url fields #2470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 15, 2025
Merged

feat: Fixed delete for additional video url fields #2470

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
77ed57c
feat: fixed delete button
vladislavkeblysh Sep 22, 2025
64c3cc7
feat: refactor after review
vladislavkeblysh Sep 24, 2025
790a658
feat: refactor after review
vladislavkeblysh Oct 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions ...ntainers/VideoEditor/components/VideoSettingsModal/components/VideoSourceWidget/hooks.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,16 +39,14 @@ export const sourceHooks = ({ dispatch, previousVideoId, setAlert }) => ({

export const fallbackHooks = ({ fallbackVideos, dispatch }) => ({
addFallbackVideo: () => dispatch(actions.video.updateField({ fallbackVideos: [...fallbackVideos, ''] })),

/**
* Deletes the first occurrence of the given videoUrl from the fallbackVideos list
* @param {string} videoUrl - the video URL to delete
*/
deleteFallbackVideo: (videoUrl) => {
const index = fallbackVideos.findIndex(video => video === videoUrl);
const updatedFallbackVideos = [
...fallbackVideos.slice(0, index),
...fallbackVideos.slice(index + 1),
];
deleteFallbackVideo: (videoIndex) => {
const updatedFallbackVideos = fallbackVideos.toSpliced(videoIndex, 1);

dispatch(actions.video.updateField({ fallbackVideos: updatedFallbackVideos }));
},
});
Expand Down
6 changes: 3 additions & 3 deletions ...ntainers/VideoEditor/components/VideoSettingsModal/components/VideoSourceWidget/index.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,8 @@ const VideoSourceWidget = () => {
<FormattedMessage {...messages.fallbackVideoMessage} />
</div>
{fallbackVideos.formValue.length > 0 ? fallbackVideos.formValue.map((videoUrl, index) => (
<Form.Row className="mt-3.5 mx-0 flex-nowrap">
// eslint-disable-next-line react/no-array-index-key
<Form.Row className="mt-3.5 mx-0 flex-nowrap" key={`${index}-${videoUrl}`}>
<Form.Group>
<Form.Control
floatingLabel={intl.formatMessage(messages.fallbackVideoLabel)}
Expand All @@ -107,13 +108,12 @@ const VideoSourceWidget = () => {
onBlur={fallbackVideos.onBlur(index)}
/>
<IconButtonWithTooltip
key={`top-delete-${videoUrl}`}
tooltipPlacement="top"
tooltipContent={intl.formatMessage(messages.deleteFallbackVideo)}
src={DeleteOutline}
iconAs={Icon}
alt={intl.formatMessage(messages.deleteFallbackVideo)}
onClick={() => deleteFallbackVideo(videoUrl)}
onClick={() => deleteFallbackVideo(index)}
/>
</Form.Group>
</Form.Row>
Expand Down
2 changes: 1 addition & 1 deletion ...ers/VideoEditor/components/VideoSettingsModal/components/VideoSourceWidget/index.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,7 @@ describe('VideoSourceWidget', () => {
expect(screen.getAllByText('Video URL').length).toBe(3); // 1 main + 2 fallback
const deleteButtons = screen.getAllByRole('button', { name: /delete/i });
fireEvent.click(deleteButtons[0]);
expect(deleteFallbackVideo).toHaveBeenCalledWith('url1');
expect(deleteFallbackVideo).toHaveBeenCalledWith(0);
});

it('calls addFallbackVideo when add button is clicked', () => {
Expand Down