Skip to content

Conversation

@navinkarkera
Copy link
Contributor

@navinkarkera navinkarkera commented Oct 22, 2025

Description

Updates navbar in library authoring page to include Team Access and Import menu options. Clicking on Team Access button opens Team management modal.

Update: As per this new PR: #2570, if admin console url is set, it should be used instead of team access modal. So updated this PR accordingly.

Useful information to include:

  • Which user roles will this change impact? "Course Author"

Supporting information

Testing instructions

Verify the new menu options.

Other information

Include anything else that will help reviewers and consumers understand the change.

  • Does this change depend on other changes elsewhere?
  • Any special concerns or limitations? For example: deprecations, migrations, security, or accessibility.

Best Practices Checklist

We're trying to move away from some deprecated patterns in this codebase. Please
check if your PR meets these recommendations before asking for a review:

  • Any new files are using TypeScript (.ts, .tsx).
  • Deprecated propTypes, defaultProps, and injectIntl patterns are not used in any new or modified code.
  • Tests should use the helpers in src/testUtils.tsx (specifically initializeMocks)
  • Do not add new fields to the Redux state/store. Use React Context to share state among multiple components.
  • Use React Query to load data from REST APIs. See any apiHooks.ts in this repo for examples.
  • All new i18n messages in messages.ts files have a description for translators to use.
  • Imports avoid using ../. To import from parent folders, use @src, e.g. import { initializeMocks } from '@src/testUtils'; instead of from '../../../../testUtils'

@openedx-webhooks openedx-webhooks added open-source-contribution PR author is not from Axim or 2U core contributor PR author is a Core Contributor (who may or may not have write access to this repo). labels Oct 22, 2025
@openedx-webhooks
Copy link

openedx-webhooks commented Oct 22, 2025

Thanks for the pull request, @navinkarkera!

This repository is currently maintained by @bradenmacdonald.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.


Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@github-project-automation github-project-automation bot moved this to Needs Triage in Contributions Oct 22, 2025
@navinkarkera navinkarkera force-pushed the navin/fal-4264/lib-navbar branch from 90b269d to 56705a4 Compare October 22, 2025 11:56
@mphilbrick211 mphilbrick211 moved this from Needs Triage to Waiting on Author in Contributions Oct 22, 2025
@codecov
Copy link

codecov bot commented Oct 23, 2025

Codecov Report

❌ Patch coverage is 98.14815% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 94.82%. Comparing base (36c9eba) to head (573e864).
⚠️ Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
...ibrary-authoring/library-team/LibraryTeamModal.tsx 85.71% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2556   +/-   ##
=======================================
  Coverage   94.81%   94.82%           
=======================================
  Files        1225     1226    +1     
  Lines       27481    27523   +42     
  Branches     6187     6193    +6     
=======================================
+ Hits        26056    26098   +42     
+ Misses       1367     1354   -13     
- Partials       58       71   +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@rpenido rpenido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
Thank you for your work, @navinkarkera!

  • I tested this using the instructions from the PR
  • I read through the code
  • I checked for accessibility issues
  • Includes documentation

Copy link
Contributor

@ChrisChV ChrisChV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks!

@mphilbrick211 mphilbrick211 added the FC Relates to an Axim Funded Contribution project label Oct 29, 2025
@navinkarkera navinkarkera marked this pull request as ready for review November 3, 2025 05:00
@navinkarkera navinkarkera force-pushed the navin/fal-4264/lib-navbar branch from e88c7cd to 2243e86 Compare November 3, 2025 06:47
@navinkarkera navinkarkera force-pushed the navin/fal-4264/lib-navbar branch from 2243e86 to 573e864 Compare November 3, 2025 06:50
@navinkarkera
Copy link
Contributor Author

@rpenido @ChrisChV I made some changes to this PR to make it compatible with new changes in repo:

Update: As per this new PR: #2570, if admin console url is set, it should be used instead of team access modal. So updated this PR accordingly.

The last two commits include the new changes, please take a look.

Copy link
Contributor

@ChrisChV ChrisChV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@navinkarkera Looks good! Thanks!

👍

  • I tested this: I tested the two latest commits about the team access changes
  • I read through the code and considered the security, stability and performance implications of the changes.
  • I tested that the UI can be used with a keyboard only (tab order, keyboard controls).
  • Includes tests for bugfixes and/or features added.
  • Includes documentation

@ChrisChV ChrisChV merged commit 436ac31 into openedx:master Nov 3, 2025
7 checks passed
@github-project-automation github-project-automation bot moved this from Waiting on Author to Done in Contributions Nov 3, 2025
@ChrisChV ChrisChV deleted the navin/fal-4264/lib-navbar branch November 3, 2025 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core contributor PR author is a Core Contributor (who may or may not have write access to this repo). FC Relates to an Axim Funded Contribution project open-source-contribution PR author is not from Axim or 2U

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants