feat: [FC-0044] Course unit page - Unit creation button logic and refactoring #831

PKulkoRaccoonGang · 2024-02-13T10:49:44Z

Settings

EDX_PLATFORM_REPOSITORY: https://github.com/openedx/edx-platform.git
EDX_PLATFORM_VERSION: master

TUTOR_GROVE_WAFFLE_FLAGS:
  - name: contentstore.new_studio_mfe.use_new_unit_page
    everyone: true

TUTOR_GROVE_MFE_LMS_COMMON_SETTINGS:
  MFE_CONFIG:
    ENABLE_UNIT_PAGE: true

Description

This pull request is a logical continuation of optimizing the CMS of the navigation widget for course units. The second refactoring stage was carried out which will end in the next pull request to transfer the navigation widget from the MFE Learning. In addition, the functionality of a button to create a new unit for the Course unit page was implemented.

The primary features were implemented:

Course unit switch widget refactoring: preparations have been made for the final changes to replace LMS endpoints.
Unit creation button logic: the functionality of a button to create a new unit for the Course unit page was implemented.

Issue: openedx/platform-roadmap#321

Developer notes

The code base for this pull request does not provide test coverage for the Course unit switch widget.
Current changes to the module switching widget are in preparation for the final changes to replace the LMS endpoints.
In the upcoming pull request, the LMS endpoints of the MFE Learning will be substituted with distinct and independent endpoints from the CMS.

Design

Figma design

Testing instructions

Run master devstack.
Start platform make dev.up.lms+cms+frontend-app-course-authoring and make checkout on this branch.
Enable the new Unit page by adding a waffle flag contentstore.new_studio_mfe.use_new_unit_page in the CMS admin panel.
Make sure that the MFE setting ENABLE_UNIT_PAGE=true is enabled.
Go to the Course Unit page from the Course Outline page.
Make sure the course you are viewing is not outdated.
Publish all sections on the Course Outline page.
Click on the add new unit button.

openedx-webhooks · 2024-02-13T10:49:49Z

Thanks for the pull request, @PKulkoRaccoonGang! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

supporting documentation
Open edX discussion forum threads
timeline information ("this must be merged by XX date", and why that is)
partner information ("this is a course on edx.org")
any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

codecov · 2024-02-13T10:58:25Z

Codecov Report

Attention: Patch coverage is 92.41379% with 11 lines in your changes are missing coverage. Please review.

Project coverage is 90.39%. Comparing base (76bb8e8) to head (27adcc9).
Report is 2 commits behind head on master.

Files	Patch %	Lines
src/course-unit/data/thunk.js	76.47%	4 Missing ⚠️
src/course-unit/add-component/AddComponent.jsx	94.59%	2 Missing ⚠️
...nce/sequence-navigation/SequenceNavigationTabs.jsx	80.00%	2 Missing ⚠️
src/course-unit/data/slice.js	66.66%	2 Missing ⚠️
src/course-unit/hooks.jsx	93.75%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #831      +/-   ##
==========================================
+ Coverage   89.27%   90.39%   +1.11%     
==========================================
  Files         551      554       +3     
  Lines        9738     9826      +88     
  Branches     2099     2110      +11     
==========================================
+ Hits         8694     8882     +188     
+ Misses        996      910      -86     
+ Partials       48       34      -14

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

open-craft-grove · 2024-02-14T17:44:27Z

Sandbox deployment successful.

Sandbox LMS is available at https://pr-831-ba9a65.sandboxes.opencraft.hosting
Sandbox Studio is available at https://studio.pr-831-ba9a65.sandboxes.opencraft.hosting

Instance Tutor config : https://axim-sandbox-build-logs-4626178240.nyc3.digitaloceanspaces.com/pr-831-ba9a65-51564656-6173465303-tutor-config.yml
Instance Grove config : https://axim-sandbox-build-logs-4626178240.nyc3.digitaloceanspaces.com/pr-831-ba9a65-51564656-6173465303-grove-config.yml
Instance Python requirements : https://axim-sandbox-build-logs-4626178240.nyc3.digitaloceanspaces.com/pr-831-ba9a65-51564656-6173465303-tutor-requirements.txt

open-craft-grove · 2024-02-15T10:09:10Z

Sandbox deployment failed.

Check failure logs here https://axim-sandbox-build-logs-4626178240.nyc3.digitaloceanspaces.com/pr-831-ba9a65-51564656-6178704557.log

Instance Tutor config : https://axim-sandbox-build-logs-4626178240.nyc3.digitaloceanspaces.com/pr-831-ba9a65-51564656-6178704557-tutor-config.yml
Instance Grove config : https://axim-sandbox-build-logs-4626178240.nyc3.digitaloceanspaces.com/pr-831-ba9a65-51564656-6178704557-grove-config.yml
Instance Python requirements : https://axim-sandbox-build-logs-4626178240.nyc3.digitaloceanspaces.com/pr-831-ba9a65-51564656-6178704557-tutor-requirements.txt

Please check the settings and requirements and retry deployment by updating the pull request description or pushing a new commit

open-craft-grove · 2024-02-16T12:24:02Z

Sandbox deployment successful.

Sandbox LMS is available at https://pr-831-ba9a65.sandboxes.opencraft.hosting
Sandbox Studio is available at https://studio.pr-831-ba9a65.sandboxes.opencraft.hosting

Instance Tutor config : https://axim-sandbox-build-logs-4626178240.nyc3.digitaloceanspaces.com/pr-831-ba9a65-51564656-6189508588-tutor-config.yml
Instance Grove config : https://axim-sandbox-build-logs-4626178240.nyc3.digitaloceanspaces.com/pr-831-ba9a65-51564656-6189508588-grove-config.yml
Instance Python requirements : https://axim-sandbox-build-logs-4626178240.nyc3.digitaloceanspaces.com/pr-831-ba9a65-51564656-6189508588-tutor-requirements.txt

open-craft-grove · 2024-02-19T12:37:19Z

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

… page components (#118) * feat: added modal windows for course unit page components * refactor: code refactoring * refactor: added translations * refactor: refactoring after review * refactor: after review

arbrandes

It works, and I like the direction of the refactor. I have one nit about the renaming of TitleEditForm to EditTitleForm, though, but only because similar variables have not been similarly changed. (If you want to change that, totally fine, but we should probably commit to changing the other ones too.)

I don't mind the failure in coverage, at least for now.

arbrandes · 2024-02-23T16:52:14Z

src/CourseAuthoringRoutes.jsx

@@ -73,6 +73,7 @@ const CourseAuthoringRoutes = () => {
        />
        {DECODED_ROUTES.COURSE_UNIT.map((path) => (
          <Route
+            key={path}


Non-blocking, just a question. wondering how it was working before. We probably had warnings, right?

Yes, a warning about the need to add a key for the element that is being mapped

src/course-unit/CourseUnit.jsx

open-craft-grove · 2024-02-26T09:08:30Z

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

PKulkoRaccoonGang · 2024-02-26T09:22:50Z

@arbrandes Thank you! Your wishes were taken into account + test coverage increased after rolling back the renaming of variables and Sandbox deployment was successful 🚀

arbrandes · 2024-02-27T14:44:33Z

Thank you for addressing my comments!

openedx-webhooks · 2024-02-27T14:44:46Z

@PKulkoRaccoonGang 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Feb 13, 2024

PKulkoRaccoonGang marked this pull request as draft February 13, 2024 10:49

PKulkoRaccoonGang changed the title ~~feat: New unit btn and refactoring~~ feat: [FC-0044] Course unit page - Unit creation button logic and refactoring Feb 13, 2024

PKulkoRaccoonGang force-pushed the Peter_Kulko/new-unit-btn-and-refactoring branch from 65db5ac to 3ac069d Compare February 13, 2024 11:25

PKulkoRaccoonGang self-assigned this Feb 13, 2024

PKulkoRaccoonGang marked this pull request as ready for review February 13, 2024 11:34

PKulkoRaccoonGang requested review from KristinAoki and arbrandes February 13, 2024 11:36

PKulkoRaccoonGang mentioned this pull request Feb 13, 2024

feat: [FC-0044] Course unit page - Display sidebar component #832

Merged

arbrandes added the create-sandbox open-craft-grove should create a sandbox environment from this PR label Feb 14, 2024

PKulkoRaccoonGang force-pushed the Peter_Kulko/new-unit-btn-and-refactoring branch from 79d5a2d to 5e9bc34 Compare February 15, 2024 09:48

PKulkoRaccoonGang and others added 2 commits February 19, 2024 13:39

feat: Unit creation button logic and refactoring

1f0f431

fix: [AXIMST-371] fix correct internal route on create new unit (#114)

556001c

PKulkoRaccoonGang force-pushed the Peter_Kulko/new-unit-btn-and-refactoring branch from 5e9bc34 to 556001c Compare February 19, 2024 11:49

feat: [AXIMST-19, 20, 22] Course unit - Modal windows for course unit…

54e580a

… page components (#118) * feat: added modal windows for course unit page components * refactor: code refactoring * refactor: added translations * refactor: refactoring after review * refactor: after review

PKulkoRaccoonGang mentioned this pull request Feb 19, 2024

feat: [FC-0044] Course unit page - Modal windows for course unit page components #845

Merged

KristinAoki approved these changes Feb 23, 2024

View reviewed changes

arbrandes requested changes Feb 23, 2024

View reviewed changes

refactor: refactoring after review

27adcc9

PKulkoRaccoonGang requested a review from arbrandes February 26, 2024 09:23

arbrandes approved these changes Feb 27, 2024

View reviewed changes

arbrandes merged commit 6b57ce3 into openedx:master Feb 27, 2024
6 checks passed

arbrandes mentioned this pull request Mar 19, 2024

New Unit Page (Studio MFE conversion) openedx/platform-roadmap#321

Open

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: [FC-0044] Course unit page - Unit creation button logic and refactoring #831

feat: [FC-0044] Course unit page - Unit creation button logic and refactoring #831

PKulkoRaccoonGang commented Feb 13, 2024 •

edited by arbrandes

Loading

openedx-webhooks commented Feb 13, 2024 •

edited

Loading

codecov bot commented Feb 13, 2024 •

edited

Loading

open-craft-grove commented Feb 14, 2024

open-craft-grove commented Feb 15, 2024

open-craft-grove commented Feb 16, 2024

open-craft-grove commented Feb 19, 2024

arbrandes left a comment •

edited

Loading

arbrandes Feb 23, 2024

PKulkoRaccoonGang Feb 25, 2024

open-craft-grove commented Feb 26, 2024

PKulkoRaccoonGang commented Feb 26, 2024 •

edited

Loading

arbrandes commented Feb 27, 2024

openedx-webhooks commented Feb 27, 2024

feat: [FC-0044] Course unit page - Unit creation button logic and refactoring #831

feat: [FC-0044] Course unit page - Unit creation button logic and refactoring #831

Conversation

PKulkoRaccoonGang commented Feb 13, 2024 • edited by arbrandes Loading

Description

Developer notes

Design

Testing instructions

openedx-webhooks commented Feb 13, 2024 • edited Loading

codecov bot commented Feb 13, 2024 • edited Loading

Codecov Report

open-craft-grove commented Feb 14, 2024

open-craft-grove commented Feb 15, 2024

open-craft-grove commented Feb 16, 2024

open-craft-grove commented Feb 19, 2024

arbrandes left a comment • edited Loading

Choose a reason for hiding this comment

arbrandes Feb 23, 2024

Choose a reason for hiding this comment

PKulkoRaccoonGang Feb 25, 2024

Choose a reason for hiding this comment

open-craft-grove commented Feb 26, 2024

PKulkoRaccoonGang commented Feb 26, 2024 • edited Loading

arbrandes commented Feb 27, 2024

openedx-webhooks commented Feb 27, 2024

PKulkoRaccoonGang commented Feb 13, 2024 •

edited by arbrandes

Loading

openedx-webhooks commented Feb 13, 2024 •

edited

Loading

codecov bot commented Feb 13, 2024 •

edited

Loading

arbrandes left a comment •

edited

Loading

PKulkoRaccoonGang commented Feb 26, 2024 •

edited

Loading