feat: [FC-0044] Unit page - Manage access modal (unit & xblocks) #901

ihor-romaniuk · 2024-03-14T15:07:19Z

Settings

EDX_PLATFORM_REPOSITORY: https://github.com/openedx/edx-platform.git
EDX_PLATFORM_VERSION: master

TUTOR_GROVE_WAFFLE_FLAGS:
  - name: contentstore.new_studio_mfe.use_new_unit_page
    everyone: true

TUTOR_GROVE_MFE_LMS_COMMON_SETTINGS: |
  MFE_CONFIG["ENABLE_UNIT_PAGE"] = True
  MFE_CONFIG["ENABLE_NEW_EDITOR_PAGES"] = True

Description

This pull request introduces a crucial feature to our platform: the ability to manage content visibility, specifically access rights, for both course units and course XBlocks. We empower educators to finely control access rights.

Reuse the ConfigureModal component for consistency across the application.

Issue: openedx/platform-roadmap#321

Depends on:

feat: [FC-0044] Manage access API edx-platform#34360

Design

https://www.figma.com/file/YeKFwSpyLaJFDs3f3p3TSa/Studio-1%3A1-mock-ups?node-id=599%3A23595

Testing instructions

Run master devstack.
Start platform make dev.up.lms+cms+frontend-app-course-authoring and make checkout on this branch.
Enable new Unit page by adding a waffle flad contentstore.new_studio_mfe.use_new_unit_page in CMS admin panel.
Go to Course Unit page from the Course Outline page.
Make sure the course you are viewing is not outdated.
Publish all sections on the Course Outline page.

openedx-webhooks · 2024-03-14T15:07:24Z

Thanks for the pull request, @ihor-romaniuk! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

supporting documentation
Open edX discussion forum threads
timeline information ("this must be merged by XX date", and why that is)
partner information ("this is a course on edx.org")
any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

codecov · 2024-03-14T15:26:39Z

Codecov Report

Attention: Patch coverage is 97.61905% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 91.98%. Comparing base (99a144a) to head (8e145d3).
Report is 8 commits behind head on master.

❗ Current head 8e145d3 differs from pull request most recent head df8f44f. Consider uploading reports for the commit df8f44f to get more accurate results

Files	Patch %	Lines
src/generic/configure-modal/UnitTab.jsx	81.81%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #901      +/-   ##
==========================================
- Coverage   92.00%   91.98%   -0.02%     
==========================================
  Files         612      574      -38     
  Lines       10746    10246     -500     
  Branches     2305     2234      -71     
==========================================
- Hits         9887     9425     -462     
+ Misses        830      794      -36     
+ Partials       29       27       -2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

open-craft-grove · 2024-03-14T16:39:32Z

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

ihor-romaniuk · 2024-03-18T15:29:11Z

Hello @arbrandes @KristinAoki
This Pull Request was rebased on the master branch and ready for review.

open-craft-grove · 2024-03-18T16:07:29Z

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

open-craft-grove · 2024-03-19T09:36:04Z

Sandbox deployment failed 💥
Please check the settings and requirements.
Retry deployment by pushing a new commit or updating the requirements/settings in the pull request's description.
📜 Failure Logs
ℹ️ Grove Config, Tutor Config, Tutor Requirements

arbrandes

Code looks good, except possibly for one nit. Waiting for sandbox to deploy to actually test it.

arbrandes · 2024-03-19T14:06:11Z

src/constants.js

@@ -49,3 +49,10 @@ export const DECODED_ROUTES = {
    '/container/:blockId',
  ],
 };
+
+export const COURSE_BLOCK_NAMES = /** @type {const} */ ({


Suggested change

export const COURSE_BLOCK_NAMES = /** @type {const} */ ({

export const COURSE_BLOCK_NAMES = ({

I'm all for JSDoc, but I'm not sure I like having it sprinkled piecemeal in a file. If we go for it, we should do it for all instances. (At least on a per-file basis.)

Completely agree with you.
JSDoc was deleted for this case and resolved conflicts.

open-craft-grove · 2024-03-19T14:37:37Z

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

open-craft-grove · 2024-03-19T15:09:28Z

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

open-craft-grove · 2024-03-19T18:49:37Z

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

open-craft-grove · 2024-03-21T11:57:04Z

Sandbox deployment failed 💥
Please check the settings and requirements.
Retry deployment by pushing a new commit or updating the requirements/settings in the pull request's description.
📜 Failure Logs
ℹ️ Grove Config, Tutor Config, Tutor Requirements

open-craft-grove · 2024-03-21T12:28:09Z

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

open-craft-grove · 2024-04-03T09:39:28Z

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

ihor-romaniuk · 2024-04-08T10:25:39Z

Hello @arbrandes @KristinAoki
The Pull Request was updated on the master and ready for review.
Please take a look.

open-craft-grove · 2024-04-08T11:07:04Z

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

KristinAoki

For the message.js files that you moved, can you add descriptions to each of the messages?

arbrandes

Looks great in general, but it would be good to add message descriptions, where apropriate. When done, this is good to merge, so I'll approve preemptively.

ihor-romaniuk · 2024-04-11T08:12:24Z

@KristinAoki @arbrandes All new messages were covered by descriptions and it's ready for the final check.

open-craft-grove · 2024-04-11T08:39:57Z

Sandbox deployment failed 💥
Please check the settings and requirements.
Retry deployment by pushing a new commit or updating the requirements/settings in the pull request's description.
📜 Failure Logs
ℹ️ Grove Config, Tutor Config, Tutor Requirements

GlugovGrGlib · 2024-04-15T07:54:20Z

@arbrandes This is ready to be merged!

openedx-webhooks · 2024-04-22T15:13:19Z

@ihor-romaniuk 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

ihor-romaniuk requested a review from a team as a code owner March 14, 2024 15:07

openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Mar 14, 2024

ihor-romaniuk force-pushed the romaniuk/FC-0044/unit-page-unit-visibility branch from 77d3a17 to 9f3b527 Compare March 14, 2024 15:17

ihor-romaniuk requested review from arbrandes and KristinAoki March 14, 2024 15:18

ihor-romaniuk added the create-sandbox open-craft-grove should create a sandbox environment from this PR label Mar 14, 2024

mphilbrick211 added the waiting for eng review PR is ready for review. Review and merge it, or suggest changes. label Mar 15, 2024

ihor-romaniuk force-pushed the romaniuk/FC-0044/unit-page-unit-visibility branch from 9f3b527 to 294962b Compare March 18, 2024 15:27

ihor-romaniuk force-pushed the romaniuk/FC-0044/unit-page-unit-visibility branch from 294962b to a5476d1 Compare March 19, 2024 07:51

arbrandes mentioned this pull request Mar 19, 2024

New Unit Page (Studio MFE conversion) openedx/platform-roadmap#321

Open

1 task

arbrandes requested changes Mar 19, 2024

View reviewed changes

ihor-romaniuk force-pushed the romaniuk/FC-0044/unit-page-unit-visibility branch from a5476d1 to 394fcbd Compare March 19, 2024 18:01

mphilbrick211 removed the waiting for eng review PR is ready for review. Review and merge it, or suggest changes. label Mar 20, 2024

ihor-romaniuk force-pushed the romaniuk/FC-0044/unit-page-unit-visibility branch 2 times, most recently from aa383fc to c5f3a76 Compare March 21, 2024 11:39

vladislavkeblysh mentioned this pull request Mar 27, 2024

feat: [FC-0044] Textbooks Page #890

Merged

ihor-romaniuk force-pushed the romaniuk/FC-0044/unit-page-unit-visibility branch from c5f3a76 to 8e145d3 Compare April 3, 2024 08:43

feat: [FC-0044] Unit page - Manage access modal (unit & xblocks)

1d6fb7b

ihor-romaniuk force-pushed the romaniuk/FC-0044/unit-page-unit-visibility branch from 8e145d3 to 1d6fb7b Compare April 8, 2024 10:16

KristinAoki reviewed Apr 10, 2024

View reviewed changes

arbrandes approved these changes Apr 10, 2024

View reviewed changes

fix: add message description

df8f44f

KristinAoki merged commit 6ec44b5 into openedx:master Apr 22, 2024
4 checks passed

ihor-romaniuk deleted the romaniuk/FC-0044/unit-page-unit-visibility branch April 23, 2024 06:35

PKulkoRaccoonGang added create-sandbox open-craft-grove should create a sandbox environment from this PR and removed create-sandbox open-craft-grove should create a sandbox environment from this PR labels Oct 23, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: [FC-0044] Unit page - Manage access modal (unit & xblocks) #901

feat: [FC-0044] Unit page - Manage access modal (unit & xblocks) #901

ihor-romaniuk commented Mar 14, 2024 •

edited by arbrandes

Loading

openedx-webhooks commented Mar 14, 2024

codecov bot commented Mar 14, 2024 •

edited

Loading

open-craft-grove commented Mar 14, 2024

ihor-romaniuk commented Mar 18, 2024

open-craft-grove commented Mar 18, 2024

open-craft-grove commented Mar 19, 2024

arbrandes left a comment

arbrandes Mar 19, 2024

ihor-romaniuk Mar 19, 2024

open-craft-grove commented Mar 19, 2024

open-craft-grove commented Mar 19, 2024

open-craft-grove commented Mar 19, 2024

open-craft-grove commented Mar 21, 2024

open-craft-grove commented Mar 21, 2024

open-craft-grove commented Apr 3, 2024

ihor-romaniuk commented Apr 8, 2024

open-craft-grove commented Apr 8, 2024

KristinAoki left a comment

arbrandes left a comment

ihor-romaniuk commented Apr 11, 2024

open-craft-grove commented Apr 11, 2024

GlugovGrGlib commented Apr 15, 2024

openedx-webhooks commented Apr 22, 2024

	export const COURSE_BLOCK_NAMES = /** @type {const} */ ({
	export const COURSE_BLOCK_NAMES = ({

feat: [FC-0044] Unit page - Manage access modal (unit & xblocks) #901

feat: [FC-0044] Unit page - Manage access modal (unit & xblocks) #901

Conversation

ihor-romaniuk commented Mar 14, 2024 • edited by arbrandes Loading

Description

Depends on:

Design

Testing instructions

openedx-webhooks commented Mar 14, 2024

codecov bot commented Mar 14, 2024 • edited Loading

Codecov Report

open-craft-grove commented Mar 14, 2024

ihor-romaniuk commented Mar 18, 2024

open-craft-grove commented Mar 18, 2024

open-craft-grove commented Mar 19, 2024

arbrandes left a comment

Choose a reason for hiding this comment

arbrandes Mar 19, 2024

Choose a reason for hiding this comment

ihor-romaniuk Mar 19, 2024

Choose a reason for hiding this comment

open-craft-grove commented Mar 19, 2024

open-craft-grove commented Mar 19, 2024

open-craft-grove commented Mar 19, 2024

open-craft-grove commented Mar 21, 2024

open-craft-grove commented Mar 21, 2024

open-craft-grove commented Apr 3, 2024

ihor-romaniuk commented Apr 8, 2024

open-craft-grove commented Apr 8, 2024

KristinAoki left a comment

Choose a reason for hiding this comment

arbrandes left a comment

Choose a reason for hiding this comment

ihor-romaniuk commented Apr 11, 2024

open-craft-grove commented Apr 11, 2024

GlugovGrGlib commented Apr 15, 2024

openedx-webhooks commented Apr 22, 2024

ihor-romaniuk commented Mar 14, 2024 •

edited by arbrandes

Loading

codecov bot commented Mar 14, 2024 •

edited

Loading