fix: content tags drawer width [FC-0036] #910
Conversation
openedx-webhooks
added
the
open-source-contribution
|
Thanks for the pull request, @rpenido! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
rpenido
force-pushed
the
rpenido/fal-3687-fix-content-tags-drawer-width
branch
from
553347a to
847a340
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #910 +/- ##
=======================================
Coverage 91.87% 91.87%
=======================================
Files 572 572
Lines 10058 10058
Branches 2160 2160
=======================================
Hits 9241 9241
Misses 790 790
Partials 27 27 ☔ View full report in Codecov by Sentry. |
| .pgn__sheet-component:has(#content-tags-drawer) { | ||
| min-width: max(500px, 33vw); | ||
| } | ||
|
|
||
| @media only screen and (max-width: 500px) { | ||
| .pgn__sheet-component:has(#content-tags-drawer) { | ||
| min-width: 100vw; | ||
| } | ||
| } |
There was a problem hiding this comment.
Could you raise a corresponding issue in paragon? It does seems like a severe limitation, and perhaps there can be support for different sizes for the sidebar as well.
There was a problem hiding this comment.
Done: openedx/paragon#3023
rpenido
changed the title
|
@xitij2000 could you please merge this? |
|
@rpenido 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
Description
This PR changes the
min-widthof the content tags drawer to better fit content in the screenSupporting information
Small screen (< 500px)
Normal screen (> 500px)
Testing instructions
Manage Tagsbutton in the Side bar of the unitPrivate ref: FAL-3687