-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: [FC-0044] Unit page - display component support label #913
feat: [FC-0044] Unit page - display component support label #913
Conversation
Thanks for the pull request, @ihor-romaniuk! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #913 +/- ##
=======================================
Coverage 91.94% 91.94%
=======================================
Files 571 571
Lines 10188 10195 +7
Branches 2210 2214 +4
=======================================
+ Hits 9367 9374 +7
Misses 794 794
Partials 27 27 ☔ View full report in Codecov by Sentry. |
id: 'course-authoring.course-unit.modal.component.support.tooltip.fully-supported', | ||
defaultMessage: 'Fully supported tools and features are available on edX, are ' | ||
+ 'fully tested, have user interfaces where applicable, and are documented in the ' | ||
+ 'official edX guides that are available on docs.edx.org.', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this message be a hyperlink?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add descriptions to each message
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Descriptions were added
e9a9742
to
dbbb2ed
Compare
Sandbox deployment successful 🚀 |
dbbb2ed
to
bf9be6c
Compare
Sandbox deployment successful 🚀 |
Sandbox deployment successful 🚀 |
@ihor-romaniuk 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
Settings
Description
This pull request adds the display of support labels for xblocks in the advanced xblocks selector modal to the unit page.
Tags in the modal window as "Fully supported", "Provisionally supported" or "Not supported".
Issue: openedx/platform-roadmap#321
Developer notes
The initial 1 commit in this PR is temporary. Once the #912 is merged, the second commit of this PR will become the main commit.
Design
https://www.figma.com/file/YeKFwSpyLaJFDs3f3p3TSa/Studio-1%3A1-mock-ups?node-id=599%3A23595
Testing instructions
contentstore.new_studio_mfe.use_new_unit_page
in CMS admin panel.