Migrate off paragon modal deprecated component #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #95 +/- ##
=======================================
Coverage 82.32% 82.32%
=======================================
Files 46 46
Lines 679 679
Branches 132 132
=======================================
Hits 559 559
Misses 120 120
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
26 tasks
justinhynes
reviewed
Jun 2, 2023
| <ModalDialog.Footer> | ||
| <ActionRow> | ||
| <ModalDialog.CloseButton variant="link"> | ||
| Close |
There was a problem hiding this comment.
This looks like hard-coded English. Can we resource this string?
There was a problem hiding this comment.
Implemented this message through FormattedMessage i18n format.
justinhynes
requested changes
Jun 2, 2023
Mashal-m
force-pushed
the
mashal-m/paragon-modal-deprecation
branch
from
1f58e49
to
30810e0
Compare
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #95 +/- ##
=======================================
Coverage 83.01% 83.01%
=======================================
Files 46 46
Lines 683 683
Branches 132 132
=======================================
Hits 567 567
Misses 116 116
☔ View full report in Codecov by Sentry. |
justinhynes
approved these changes
Jun 5, 2023
snglth
pushed a commit
to Abstract-Tech/community-theme-communications
that referenced
this pull request
Jan 9, 2024
* refactor: migrate off paragon modal deprecated component * refactor: migrate off paragon modal deprecated component * refactor: resource the close button string * refactor: remove extra file * refactor: add message in messages file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Migrate off deprecated Paragon components
Migrate off paragon modal deprecation ViewEmailModal.jsx