fix: Fix rows counter in the Edit Grade modal window

[Lunyachek]

TL;DR - The problem was in the rows counter in the Edit Grades modal window. First digit - number of lines excluding the last line with the form. Second digit - grades data. And our proposal is to include last row with form to common counting

What changed?

FYI: @openedx/content-aurora

[openedx-webhooks]

Thanks for the pull request, @Lunyachek! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

• supporting documentation
• Open edX discussion forum threads
• timeline information ("this must be merged by XX date", and why that is)
• partner information ("this is a course on edx.org")
• any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (ef8e20f) to head (494eabc).
Report is 2 commits behind head on master.

❗ Current head 494eabc differs from pull request most recent head 18cede4. Consider uploading reports for the commit 18cede4 to get more accurate results

Additional details and impacted files

@@             Coverage Diff             @@
##           master      #310      +/-   ##
===========================================
+ Coverage   94.98%   100.00%   +5.01%     
===========================================
  Files         139       109      -30     
  Lines        1355      1265      -90     
  Branches      264       248      -16     
===========================================
- Hits         1287      1265      -22     
+ Misses         60         0      -60     
+ Partials        8         0       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[mphilbrick211]

@jmakowski1123 @ProductRyan flagging this as needing product review to move forward. Thanks!

[jmakowski1123]

Since this fix has multiple PRs associated with it (#310 and #311), I've created a Product Feature ticket. It's currently undergoing Product Review in that Feature Ticket.

[Daniel-hershel]

Hey, I approved this on the product ticket noted above

[mphilbrick211]

Hi @mattcarter @openedx/content-aurora! This is ready for your review. If all looks good, please merge as well. Thank you!

[mphilbrick211]

Hi @mattcarter @openedx/content-aurora! This is ready for your review. If all looks good, please merge as well. Thank you!

Hi @mattcarter - friendly ping on this :)

[mphilbrick211]

Hi @mattcarter and @openedx/content-aurora! Would someone be able to review/merge this? Thanks!

In the meantime, @Lunyachek - could you please take a look at resolving the branch conflicts?

[mphilbrick211]

Hi @Lunyachek - just checking to see if you're able to resolve the conflicts here? Thanks!

[mphilbrick211]

Hi @Lunyachek! Friendly follow-up on this!

[mphilbrick211]

Hi @Lunyachek! Just checking in to see if you plan to pursue this PR?

[jmakowski1123]

This one has product approval: openedx/platform-roadmap#236 (comment)

[mphilbrick211]

Hi @Lunyachek - closing this for now. In order to pursue, we need the branch conflicts resolved. If you'd like to reopen, please let us know.

[openedx-webhooks]

@Lunyachek Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future.

[Lunyachek]

@mphilbrick211 Hello. Yes, I want to reopen this PR. I also made a backport to the quince branch - #389

[mphilbrick211]

Hi @Lunyachek! I've reopened. Would you mind resolving the branch conflicts? Thanks!

[Lunyachek]

Hi @Lunyachek! I've reopened. Would you mind resolving the branch conflicts? Thanks!

Thank you! Conflicts resolved

[mphilbrick211]

Hi @arbrandes! Would you mind taking a look at this?

[arbrandes]

Looks good, thanks!