feat: don't show masters-only columns for courses without a masters track #324
+70
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jansenk
force-pushed
the
jkantor/masters-columns
branch
from
fc4bacb
to
32be24c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #324 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 122 122
Lines 1274 1281 +7
Branches 250 253 +3
=========================================
+ Hits 1274 1281 +7 ☔ View full report in Codecov by Sentry. |
farhaanbukhsh
changed the title
|
@mphilbrick211 This will require a proposal. @jansenk Are you willing to pursue these changes? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only show masters-only columns when a course has a master's track.
No Masters track / mode:
Masters track / mode
Note: This is based on TRACKS. As shown in the screenshot above, you can technically have a student who is enrolled as "masters" without a masters track in a course BUT this is only possible through manual developer modification and can't happen in normal user-facing environments.
FYI: @openedx/content-aurora