-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: file input handler #371
fix: file input handler #371
Conversation
hasFile run only once, it will always be null
Thanks for the pull request, @DmytroAlipov! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## open-release/palm.master #371 +/- ##
============================================================
Coverage ? 100.00%
============================================================
Files ? 122
Lines ? 1268
Branches ? 249
============================================================
Hits ? 1268
Misses ? 0
Partials ? 0 ☔ View full report in Codecov by Sentry. |
Hi @openedx/content-aurora! I think this is ready for merge, the master has already been merged. |
Looked through the diff - looks exactly the same as for master. |
@DmytroAlipov 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
This is a backport from the master branch.
hasFile run only once, it will always be null