fix: Route with PUBLIC_PATH #375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this change, the MFE would fail to render with any PUBLIC_PATH set. Because that is now handled entirely by `frontend-platform`, we can avoid referring to PUBLIC_PATH entirely, here.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #375 +/- ##
==========================================
- Coverage 94.98% 94.98% -0.01%
==========================================
Files 140 140
Lines 1357 1356 -1
Branches 264 264
==========================================
- Hits 1289 1288 -1
Misses 60 60
Partials 8 8 ☔ View full report in Codecov by Sentry. |
|
This has been both explicitly and implicitly reviewed in Quince, so I'm taking the liberty of merging it in master as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change, the MFE would fail to render with any PUBLIC_PATH set. Because that is now handled entirely by
frontend-platform, we can avoid referring to PUBLIC_PATH at all.Developer Checklist
Testing Instructions
Using Tutor nightly in dev mode, without this patch the gradebook only shows a blank page. With it, it actually renders.