-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Grade value is displayed in the modal #390
fix: Grade value is displayed in the modal #390
Conversation
Thanks for the pull request, @DmytroAlipov! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
Hi @arbrandes and @farhaanbukhsh! Would one of you be able to take a look at this? Thanks! |
@mphilbrick211 I can have a look at this in this sprint :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
@@ -22,7 +22,7 @@ export const HistoryKeys = StrictDict({ | |||
*/ | |||
export const ModalHeaders = () => { | |||
const { assignmentName, updateUserName } = selectors.app.useModalData(); | |||
const { currentGrade, originalGrade } = selectors.grades.useGradeData(); | |||
const { gradeOverrideCurrentEarnedGradedOverride, gradeOriginalEarnedGraded } = selectors.grades.useGradeData(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are horribly long variable names, but yeah, not much we can do.
@DmytroAlipov 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
TL;DR -
Original Grade
value is not displayed:This value was available on the Palm release:
That's how it was in Palm
This is the data contained in
selectors.grades.useGradeData
:Developer Checklist
Testing Instructions
Instructor
tabStudent admin
View Gradebook
Original Grade
valueAfter these fixes everything works correctly:
FYI: @openedx/content-aurora