fix: variant based assignment bug fixes

openedx · Sep 17, 2024 · 03d2ba9 · 03d2ba9
1 parent b2a91d6
commit 03d2ba9
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/src/components/course/course-header/CourseImportantDates.jsx b/src/components/course/course-header/CourseImportantDates.jsx
@@ -92,8 +92,9 @@ const CourseImportantDates = () => {
     const soonestExpiringAllocatedAssignment = courseMetadata.availableCourseRuns.find(
       (courseRun) => courseRun.key === soonestExpiringAssignment?.contentKey,
     );
-    soonestExpiringAllocatedAssignmentCourseStartDate = soonestExpiringAllocatedAssignment
-      && getNormalizedStartDate(soonestExpiringAllocatedAssignment);
+    if (soonestExpiringAllocatedAssignment) {
+      soonestExpiringAllocatedAssignmentCourseStartDate = getNormalizedStartDate(soonestExpiringAllocatedAssignment);
+    }
   }
   // Parse logic of date existence and labels
   const enrollByDate = soonestExpirationDate ?? null;

diff --git a/src/components/course/data/utils.jsx b/src/components/course/data/utils.jsx
@@ -91,12 +91,11 @@ export const getNormalizedStartDate = ({
     return todayToIso;
   }
   const startDateIso = dayjs(start).toISOString();
-  if (isCourseSelfPaced({ pacingType })) {
+  if (isCourseSelfPaced(pacingType)) {
     if (hasTimeToComplete({ end, weeksToComplete }) || isWithinMinimumStartDateThreshold({ start })) {
       // always today's date (incentives enrollment)
       return todayToIso;
     }
-    return startDateIso;
   }
   return startDateIso;
 };