Add is_active to request querystring (#235)

So that users only see valid coupons
openedx · Mar 8, 2021 · 6652188 · 6652188
1 parent c302f00
commit 6652188
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/src/components/enterprise-user-subsidy/data/hooks.jsx b/src/components/enterprise-user-subsidy/data/hooks.jsx
@@ -85,6 +85,7 @@ export function useOffers(enterpriseId) {
         fetchOffers({
           enterprise_uuid: enterpriseId,
           full_discount_only: 'True', // Must be a string because the API does a string compare not a true JSON boolean compare.
+          is_active: 'True',
         },
         dispatch);
       }

diff --git a/src/components/enterprise-user-subsidy/tests/UserSubsidy.test.jsx b/src/components/enterprise-user-subsidy/tests/UserSubsidy.test.jsx
@@ -139,6 +139,7 @@ describe('UserSubsidy', () => {
       expect(fetchOffers).toHaveBeenCalledWith({
         enterprise_uuid: TEST_ENTERPRISE_UUID,
         full_discount_only: 'True',
+        is_active: 'True',
       });
       await waitFor(() => {
         expect(screen.queryByText('Has access: false')).toBeInTheDocument();
@@ -172,6 +173,7 @@ describe('UserSubsidy', () => {
       expect(fetchOffers).toHaveBeenCalledWith({
         enterprise_uuid: TEST_ENTERPRISE_UUID,
         full_discount_only: 'True',
+        is_active: 'True',
       });
 
       await waitFor(() => {
@@ -206,6 +208,7 @@ describe('UserSubsidy', () => {
       expect(fetchOffers).toHaveBeenCalledWith({
         enterprise_uuid: TEST_ENTERPRISE_UUID,
         full_discount_only: 'True',
+        is_active: 'True',
       });
 
       await waitFor(() => {
@@ -238,7 +241,7 @@ describe('UserSubsidy', () => {
       expect(fetchEnterpriseCustomerSubscriptionPlan).toHaveBeenCalledWith(TEST_ENTERPRISE_UUID);
       expect(fetchSubscriptionLicensesForUser).toHaveBeenCalledWith(TEST_ENTERPRISE_UUID);
       expect(fetchOffers).toHaveBeenCalledTimes(1);
-      expect(fetchOffers).toHaveBeenCalledWith({ enterprise_uuid: TEST_ENTERPRISE_UUID, full_discount_only: 'True' });
+      expect(fetchOffers).toHaveBeenCalledWith({ enterprise_uuid: TEST_ENTERPRISE_UUID, full_discount_only: 'True', is_active: 'True' });
 
       await waitFor(() => {
         expect(screen.queryByText('Offers count: 0')).toBeInTheDocument();