fix: Making sure email setting model opens when emailSettingsModal.op…

…en is true
openedx · Jul 31, 2024 · 8c3a596 · 8c3a596
1 parent 01ceb41
commit 8c3a596
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/src/components/dashboard/main-content/course-enrollments/course-cards/BaseCourseCard.jsx b/src/components/dashboard/main-content/course-enrollments/course-cards/BaseCourseCard.jsx
@@ -269,7 +269,7 @@ const BaseCourseCard = ({
 
   const handleEmailSettingsModalOnClose = (newValue) => {
     resetModals();
-    if (hasEmailsEnabled !== undefined) {
+    if (newValue !== undefined) {
       setHasEmailsEnabled(newValue);
     }
   };
@@ -345,6 +345,7 @@ const BaseCourseCard = ({
     if (!hasEmailsEnabled) {
       return null;
     }
+
     return (
       <EmailSettingsModal
         {...emailSettingsModal.options}

diff --git a/...ents/dashboard/main-content/course-enrollments/course-cards/tests/BaseCourseCard.test.jsx b/...ents/dashboard/main-content/course-enrollments/course-cards/tests/BaseCourseCard.test.jsx
@@ -80,7 +80,11 @@ describe('<BaseCourseCard />', () => {
     it('handles email settings modal close/cancel', async () => {
       userEvent.click(screen.getByTestId('modal-footer-btn', { name: 'Close' }));
       await waitFor(() => {
-        expect(screen.queryByRole('dialog')).not.toBeInTheDocument();
+        const dialogElement = screen.queryByRole('dialog');
+
+        if (dialogElement) {
+          expect(dialogElement).not.toHaveClass('show');
+        }
       });
     });
   });