chore: PR feedback 2

src/components/app/data/constants.js

@@ -65,5 +65,5 @@ export const ASSIGNMENT_TYPES = {
   EXPIRING: 'expiring',
 };
 
-// Start date threshold to default to today days, sets start date to today if course start date is beyond this value
+// When the start date is before this number of days before today, display the alternate start date (fixed to today).
 export const START_DATE_DEFAULT_TO_TODAY_THRESHOLD_DAYS = 14;

src/components/course/course-header/CourseImportantDates.jsx

@@ -89,7 +89,7 @@ const CourseImportantDates = () => {
   // Match soonest expiring assignment to the corresponding course start date from course metadata
   let soonestExpiringAllocatedAssignmentCourseStartDate = null;
   if (soonestExpiringAssignment) {
-    const soonestExpiringAllocatedAssignment = courseMetadata.availableCourseRuns?.find(
+    const soonestExpiringAllocatedAssignment = courseMetadata.availableCourseRuns.find(
       (courseRun) => courseRun.key === soonestExpiringAssignment?.contentKey,
     );
     soonestExpiringAllocatedAssignmentCourseStartDate = soonestExpiringAllocatedAssignment

src/components/course/data/constants.js

@@ -1,5 +1,7 @@
 import GetSmarterLogo from '../../../assets/icons/getsmarter-header-icon.svg';
 
+// The SELF and INSTRUCTOR values are keys/value pairs used specifically for pacing sourced from the
+// enterprise_course_enrollments API.
 export const COURSE_PACING_MAP = {
   SELF_PACED: 'self_paced',
   INSTRUCTOR_PACED: 'instructor_paced',

src/components/course/data/utils.jsx

@@ -31,10 +31,6 @@ import {
 
 /**
  * Determines if the course has already started. Mostly used around text formatting for tense
- * Introduces 'jitter' in the form of a 30 second offset to take into account any additional
- * formatting that takes place down stream related to setting values to today's date through dayjs()
- *
- * This should also help with reducing 'flaky' tests.
  *
  * @param start
  * @returns {boolean}
@@ -68,11 +64,11 @@ export function hasTimeToComplete(courseRun) {
 }
 
 export function isCourseSelfPaced(pacingType) {
-  return pacingType === COURSE_PACING_MAP.SELF_PACED || pacingType === COURSE_PACING_MAP.SELF;
+  return [COURSE_PACING_MAP.SELF_PACED, COURSE_PACING_MAP.SELF].includes(pacingType);
 }
 
 export function isCourseInstructorPaced(pacingType) {
-  return pacingType === COURSE_PACING_MAP.INSTRUCTOR_PACED || pacingType === COURSE_PACING_MAP.INSTRUCTOR;
+  return [COURSE_PACING_MAP.INSTRUCTOR_PACED, COURSE_PACING_MAP.INSTRUCTOR].includes(pacingType);
 }
 
 const isWithinMinimumStartDateThreshold = ({ start }) => dayjs(start).isBefore(dayjs().subtract(START_DATE_DEFAULT_TO_TODAY_THRESHOLD_DAYS, 'days'));
@@ -81,10 +77,10 @@ const isWithinMinimumStartDateThreshold = ({ start }) => dayjs(start).isBefore(d
  * If the start date of the course is before today offset by the START_DATE_DEFAULT_TO_TODAY_THRESHOLD_DAYS
  * then return today's formatted date. Otherwise, pass-through the start date in ISO format.
  *
- * @param start
- * @param pacingType
- * @param end
- * @param weeksToComplete
+ * @param {String} start
+ * @param {String} pacingType
+ * @param {String} end
+ * @param {Number} weeksToComplete
  * @returns {string}
  */
 export const getNormalizedStartDate = ({
@@ -978,23 +974,3 @@ export function getSoonestEarliestPossibleExpirationData({
     sortedExpirationAssignments: sortedByExpirationDate,
   };
 }
-
-/**
- * If the start date of the course is before today offset by the START_DATE_DEFAULT_TO_TODAY_THRESHOLD_DAYS
- * then return today's formatted date. Otherwise, pass-through the start date in ISO format.
- *
- * For cases where a start date does not exist, just return today's date.
- *
- * @param start
- * @param format
- * @returns {string}
- */
-export const setStaleCourseStartDates = ({ start }) => {
-  if (!start) {
-    return dayjs().toISOString();
-  }
-  if (dayjs(start).isBefore(dayjs().subtract(START_DATE_DEFAULT_TO_TODAY_THRESHOLD_DAYS, 'days'))) {
-    return dayjs().toISOString();
-  }
-  return dayjs(start).toISOString();
-};