Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: more consistency and clarity around late enrollment variables #1131

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

pwnage101
Copy link
Contributor

Renames the following everywhere in the codebase:

  • getLateRedemptionBufferDays -> getLateEnrollmentBufferDays
  • useLateRedemptionBufferDays -> useLateEnrollmentBufferDays
  • isEnrollableBufferDays -> lateEnrollmentBufferDays

ENT-9259

Copy link
Member

@adamstankiewicz adamstankiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👨‍🍳 💋

Renames the following everywhere in the codebase:

* getLateRedemptionBufferDays -> getLateEnrollmentBufferDays
* useLateRedemptionBufferDays -> useLateEnrollmentBufferDays
* isEnrollableBufferDays -> lateEnrollmentBufferDays

ENT-9259
Copy link

codecov bot commented Jul 24, 2024

Codecov Report

Attention: Patch coverage is 92.85714% with 1 line in your changes missing coverage. Please review.

Project coverage is 87.03%. Comparing base (e354666) to head (0ebdbd6).

Files Patch % Lines
...ts/course/routes/externalCourseEnrollmentLoader.js 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1131      +/-   ##
==========================================
- Coverage   87.03%   87.03%   -0.01%     
==========================================
  Files         388      388              
  Lines        8070     8069       -1     
  Branches     1979     1983       +4     
==========================================
- Hits         7024     7023       -1     
  Misses        997      997              
  Partials       49       49              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pwnage101 pwnage101 merged commit 2546895 into master Jul 24, 2024
7 checks passed
@pwnage101 pwnage101 deleted the pwnage101/ENT-9259-2 branch July 24, 2024 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants