Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: updated frontend-platform & frontend-build major versions along with respective packages #1089

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

BilalQamar95
Copy link
Contributor

@BilalQamar95 BilalQamar95 commented May 24, 2024

Description

  • Major version upgrades for frontend-platform & frontend-build
  • Fixed failing tests post upgrade

@BilalQamar95 BilalQamar95 self-assigned this May 24, 2024
@BilalQamar95 BilalQamar95 changed the title feat: updated jest to v29 & frontend-platform major version feat: updated frontend-platform & frontend-build major versions along with respective packages May 24, 2024
Copy link

codecov bot commented May 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.21%. Comparing base (272f6dd) to head (28cd8bb).
Report is 13 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1089   +/-   ##
=======================================
  Coverage   88.21%   88.21%           
=======================================
  Files         394      394           
  Lines        8392     8392           
  Branches     2021     2021           
=======================================
  Hits         7403     7403           
  Misses        947      947           
  Partials       42       42           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BilalQamar95
Copy link
Contributor Author

@irfanuddinahmad Can you please also add a comment as to why this PR was closed.

@irfanuddinahmad
Copy link
Contributor

@irfanuddinahmad Can you please also add a comment as to why this PR was closed.

Reopened. I thought this was inactive.

@irfanuddinahmad
Copy link
Contributor

@irfanuddinahmad Can you please also add a comment as to why this PR was closed.

Reopened. I thought this was inactive.

Can you rebase and merge soon?

@BilalQamar95
Copy link
Contributor Author

Can you rebase and merge soon?
I have rebased the PR, can be merged once it is reviewed/approved by owning squad.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants