Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: default stale start dates to today #1180
feat: default stale start dates to today #1180
Changes from 1 commit
61c8f25
4c4f65f
8cfd7d8
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[curious] Should we backlog a ticket as a follow-up story to make the Dashboard start dates have parity to other start dates with regard to
weeksToComplete
? Maybe include the ticket number in the TODO comment?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can tackle this in the follow-up PR for coverage tomorrow morning.
Check warning on line 101 in src/components/course/data/utils.jsx
Codecov / codecov/patch
src/components/course/data/utils.jsx#L101
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want test coverage on this 2 code paths?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, as discussed synchronously, the coverage can be a followup post testing on stage. Since the pipeline will be paused for both admin and learner portal, the coverage can be brought up to date with subsequent PRs tomorrow to get started on testing.
That being said there is a component that uses identical logic
useCourseRunCardHeading
which reuses the same logic which I will piggyback off of for testing 👍🏽Check warning on line 103 in src/components/course/data/utils.jsx
Codecov / codecov/patch
src/components/course/data/utils.jsx#L103
Check warning on line 994 in src/components/course/data/utils.jsx
Codecov / codecov/patch
src/components/course/data/utils.jsx#L994
Check warning on line 997 in src/components/course/data/utils.jsx
Codecov / codecov/patch
src/components/course/data/utils.jsx#L997
Check warning on line 999 in src/components/course/data/utils.jsx
Codecov / codecov/patch
src/components/course/data/utils.jsx#L999