Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure run-based assignments are taken into account on course page redirect #1196

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

adamstankiewicz
Copy link
Member

@adamstankiewicz adamstankiewicz commented Sep 18, 2024

When a learner only has an assignment available, there is logic on the course about page that checks whether or not the learner only has an allocated assignment (i.e., no other subsidies available). If the learner is assignment-only and the course is not assigned, we redirect back to the dashboard.

In the case of a run-based assignment, we were missing a check for assignment-only learners against both the assignment.contentKey vs. assignment.parentContentKey when comparing to the top-level course key in the course page route URL.

With fix

Screen.Recording.2024-09-18.at.2.17.51.PM.mov

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)
  • Ensure English strings are marked for translation. See documentation for more details.

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

Copy link

codecov bot commented Sep 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.42%. Comparing base (5bca07b) to head (8b107ac).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1196      +/-   ##
==========================================
+ Coverage   88.41%   88.42%   +0.01%     
==========================================
  Files         396      396              
  Lines        8408     8407       -1     
  Branches     2065     2061       -4     
==========================================
  Hits         7434     7434              
+ Misses        931      930       -1     
  Partials       43       43              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adamstankiewicz adamstankiewicz force-pushed the ags/fix-course-page-redirect-assignment branch from 8399a89 to 8b107ac Compare September 18, 2024 19:47
@adamstankiewicz adamstankiewicz merged commit f35543e into master Sep 18, 2024
6 checks passed
@adamstankiewicz adamstankiewicz deleted the ags/fix-course-page-redirect-assignment branch September 18, 2024 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants