-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: unlink the enterprise learner in non blocking manner #1215
Conversation
ba68968
to
0058ab0
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1215 +/- ##
=======================================
Coverage 88.43% 88.43%
=======================================
Files 399 399
Lines 8505 8519 +14
Branches 2091 2054 -37
=======================================
+ Hits 7521 7534 +13
- Misses 942 943 +1
Partials 42 42 ☔ View full report in Codecov by Sentry. |
0058ab0
to
a6778be
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from a few NITs, LGTM 👍🏻
a6778be
to
d094405
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, had a few suggestions (e.g., using StatefulButton
) and minor nits. Also wanted to sanity check why we seem to be including the enterpriseCustomer.uuid
in the modal body contents?
src/components/expired-subscription-modal/tests/ExpiredSubscriptionModal.test.jsx
Outdated
Show resolved
Hide resolved
src/components/expired-subscription-modal/tests/ExpiredSubscriptionModal.test.jsx
Outdated
Show resolved
Hide resolved
src/components/app/data/services/enterpriseCustomerUser.test.js
Outdated
Show resolved
Hide resolved
d094405
to
33bc0cd
Compare
33bc0cd
to
a69d684
Compare
8eb2c3a
to
c071b51
Compare
c071b51
to
e46fd95
Compare
Description
JIRA Ticket -> https://2u-internal.atlassian.net/browse/ENT-9665
For all changes
Only if submitting a visual change