Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: unlink the enterprise learner in non blocking manner #1215

Merged
merged 1 commit into from
Nov 1, 2024

Conversation

jajjibhai008
Copy link
Contributor

@jajjibhai008 jajjibhai008 commented Oct 30, 2024

Description
JIRA Ticket -> https://2u-internal.atlassian.net/browse/ENT-9665

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)
  • Ensure English strings are marked for translation. See documentation for more details.

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

Copy link

codecov bot commented Oct 30, 2024

Codecov Report

Attention: Patch coverage is 92.85714% with 1 line in your changes missing coverage. Please review.

Project coverage is 88.43%. Comparing base (66a5d34) to head (e46fd95).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...onents/app/data/services/enterpriseCustomerUser.js 80.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1215   +/-   ##
=======================================
  Coverage   88.43%   88.43%           
=======================================
  Files         399      399           
  Lines        8505     8519   +14     
  Branches     2091     2054   -37     
=======================================
+ Hits         7521     7534   +13     
- Misses        942      943    +1     
  Partials       42       42           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@mahamakifdar19 mahamakifdar19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from a few NITs, LGTM 👍🏻

Copy link
Member

@adamstankiewicz adamstankiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, had a few suggestions (e.g., using StatefulButton) and minor nits. Also wanted to sanity check why we seem to be including the enterpriseCustomer.uuid in the modal body contents?

@jajjibhai008 jajjibhai008 force-pushed the eahmadjaved/ENT-9665 branch 5 times, most recently from 8eb2c3a to c071b51 Compare November 1, 2024 15:26
@macdiesel macdiesel merged commit 7cfe30a into master Nov 1, 2024
6 checks passed
@macdiesel macdiesel deleted the eahmadjaved/ENT-9665 branch November 1, 2024 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants