test: Add Node 20 to CI matrix #326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #326 +/- ##
=======================================
Coverage 67.93% 67.93%
=======================================
Files 43 43
Lines 789 789
Branches 160 158 -2
=======================================
Hits 536 536
Misses 245 245
Partials 8 8 ☔ View full report in Codecov by Sentry. |
UsamaSadiq
approved these changes
Sep 3, 2024
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As a first step in the upgrade to Node 20, add it to the CI matrix as a non-blocking test.
See the tracking issue for further information.
Also as a result of renovate/edx-frontend-component-footer-edx-7.x#324 2 snapshots are failing from 1 test suite, this PR also updates the snapshots to resolve that issue.