Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: incorrectly named plugin slots #1388

Merged
merged 1 commit into from
May 16, 2024
Merged

Conversation

zacharis278
Copy link
Contributor

In my haste to merge #1368 I missed staging some files for the requested changes to align us with openedx/wg-frontend#178. This is a breaking change but no one is using these slots yet.

Copy link

codecov bot commented May 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.74%. Comparing base (257c9dc) to head (8d32a63).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1388   +/-   ##
=======================================
  Coverage   88.74%   88.74%           
=======================================
  Files         303      303           
  Lines        5224     5224           
  Branches     1330     1330           
=======================================
  Hits         4636     4636           
  Misses        572      572           
  Partials       16       16           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@schenedx schenedx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@zacharis278 zacharis278 merged commit f124c0d into master May 16, 2024
7 checks passed
@zacharis278 zacharis278 deleted the zhancock/fix-plugin-slots branch May 16, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants