feat!: organize plugin slots as components, add footer slot (#1381) #1408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…1381) BREAKING CHANGE: slot ids have been changed for consistency * `sequence_container_plugin` -> `sequence_container_slot` * `unit_title_plugin` -> `unit_title_slot`
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## open-release/redwood.master #1408 +/- ##
==============================================================
Coverage ? 88.81%
==============================================================
Files ? 306
Lines ? 5256
Branches ? 1336
==============================================================
Hits ? 4668
Misses ? 572
Partials ? 16 ☔ View full report in Codecov by Sentry. |
brian-smith-tcril
approved these changes
Jun 6, 2024
arbrandes
merged commit c8a95eb
into
openedx:open-release/redwood.master
7 checks passed
bra-i-am
pushed a commit
to eduNEXT/frontend-app-learning
that referenced
this pull request
Jul 23, 2024
…1408) BREAKING CHANGE: slot ids have been changed for consistency * `sequence_container_plugin` -> `sequence_container_slot` * `unit_title_plugin` -> `unit_title_slot` Co-authored-by: Brian Smith <[email protected]>
bra-i-am
added a commit
to eduNEXT/frontend-app-learning
that referenced
this pull request
Jul 29, 2024
* feat: [FC-0056] courseware sidebar enhancement (openedx#1398) - Display section and sequence progress - Add tracking event to the unit button - Hide the horizontal unit navigation with enabled sidebar navigation * fix: optimize scroll position observer after video fullscreen exit (openedx#1405) * feat!: organize plugin slots as components, add footer slot (openedx#1408) BREAKING CHANGE: slot ids have been changed for consistency * `sequence_container_plugin` -> `sequence_container_slot` * `unit_title_plugin` -> `unit_title_slot` Co-authored-by: Brian Smith <[email protected]> * feat(redwood): add css support and cdn compatibility (#17) * perf: add runtime theming support to redwood * fix: outline collapsible icons * fix: solve issue with overlaid input element * refactor: add frontend-platform dep from npm * refactor: rename frontend-build github branch --------- Co-authored-by: Diana Catalina Olarte <[email protected]> * fix: some variables weren't css-variables * fix: recreate package-lock --------- Co-authored-by: Ihor Romaniuk <[email protected]> Co-authored-by: Adolfo R. Brandes <[email protected]> Co-authored-by: Brian Smith <[email protected]> Co-authored-by: Diana Catalina Olarte <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A straight backport of #1381.