Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Remove support for Node 18 #1454

Merged
merged 3 commits into from
Oct 31, 2024

Conversation

BilalQamar95
Copy link
Contributor

Description

Completed upgrade to Node 20 by removing the Node 18 CI check and using .nvmrc for version to use.

See the tracking issue for further information.

@BilalQamar95 BilalQamar95 self-assigned this Sep 9, 2024
Copy link

codecov bot commented Sep 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.23%. Comparing base (64f92de) to head (1d27867).
Report is 4 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1454   +/-   ##
=======================================
  Coverage   89.23%   89.23%           
=======================================
  Files         315      315           
  Lines        5545     5545           
  Branches     1372     1372           
=======================================
  Hits         4948     4948           
- Misses        581      582    +1     
+ Partials       16       15    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bradenmacdonald
Copy link
Contributor

Note: per openedx/public-engineering#280 we can only merge this after Sumac is cut.

@bradenmacdonald
Copy link
Contributor

@BilalQamar95 Note: before merging this, we need to update it to not use matrix for the coverage upload name.

name: code-coverage-report-${{ matrix.node }}
# When we're only using Node 20, replace the line above with the following:
# name: code-coverage-report

name: code-coverage-report-20
# When we're only using Node 20, replace the line above with the following:
# name: code-coverage-report

@brian-smith-tcril brian-smith-tcril merged commit 6534347 into master Oct 31, 2024
8 checks passed
@brian-smith-tcril brian-smith-tcril deleted the bilalqamar95/node20-upgrade-3 branch October 31, 2024 19:35
@BilalQamar95 BilalQamar95 mentioned this pull request Sep 9, 2024
KristinAoki pushed a commit that referenced this pull request Nov 1, 2024
* test: Remove support for Node 18

* chore: update code coverage artifact naming
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants