-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: Remove support for Node 18 #1454
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1454 +/- ##
=======================================
Coverage 89.23% 89.23%
=======================================
Files 315 315
Lines 5545 5545
Branches 1372 1372
=======================================
Hits 4948 4948
- Misses 581 582 +1
+ Partials 16 15 -1 ☔ View full report in Codecov by Sentry. |
Note: per openedx/public-engineering#280 we can only merge this after Sumac is cut. |
@BilalQamar95 Note: before merging this, we need to update it to not use frontend-app-learning/.github/workflows/validate.yml Lines 24 to 26 in d47433e
frontend-app-learning/.github/workflows/validate.yml Lines 36 to 38 in d47433e
|
…o bilalqamar95/node20-upgrade-3
* test: Remove support for Node 18 * chore: update code coverage artifact naming
Description
Completed upgrade to Node 20 by removing the Node 18 CI check and using
.nvmrc
for version to use.See the tracking issue for further information.