Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: corrects typo in IFRAME_FEATURE_POLICY #1500

Merged

Conversation

rediris
Copy link
Contributor

@rediris rediris commented Oct 21, 2024

This is a simple fix to the IFRAME_FEATURE_POLICY, wherein a comma was used instead of a semi-colon.

Refer to the following screencap of the console for the warnings:
Screenshot 2024-10-21 at 11 50 54 AM

@openedx-webhooks
Copy link

openedx-webhooks commented Oct 21, 2024

Thanks for the pull request, @rediris!

What's next?

Please work through the following steps to get your changes ready for engineering review:

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @openedx/committers-frontend-app-learning. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Oct 21, 2024
@bradenmacdonald
Copy link
Contributor

Thanks @rediris! Looks like we need a CLA from you before we can merge though; would you mind doing that?

Copy link

codecov bot commented Oct 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.23%. Comparing base (6534347) to head (46271a3).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1500   +/-   ##
=======================================
  Coverage   89.23%   89.23%           
=======================================
  Files         317      317           
  Lines        5557     5557           
  Branches     1375     1376    +1     
=======================================
  Hits         4959     4959           
  Misses        582      582           
  Partials       16       16           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rediris
Copy link
Contributor Author

rediris commented Oct 30, 2024

Thanks @rediris! Looks like we need a CLA from you before we can merge though; would you mind doing that?

@bradenmacdonald the individual contribution CLA should be all set. Hopefully the folks at axim can confirm.

@bradenmacdonald
Copy link
Contributor

FYI @feanil @gabor-boros - this is just a typo fix so not changing the intended specs of this security policy, but I want to give you a heads up before merging because it says "Changes to it should be vetted by" the security WG.

@bradenmacdonald bradenmacdonald enabled auto-merge (rebase) November 4, 2024 17:44
@bradenmacdonald bradenmacdonald merged commit 6813872 into openedx:master Nov 4, 2024
5 checks passed
@bradenmacdonald
Copy link
Contributor

Thanks for the fix, @rediris !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants