-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: corrects typo in IFRAME_FEATURE_POLICY #1500
fix: corrects typo in IFRAME_FEATURE_POLICY #1500
Conversation
Thanks for the pull request, @rediris! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently maintained by Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Thanks @rediris! Looks like we need a CLA from you before we can merge though; would you mind doing that? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1500 +/- ##
=======================================
Coverage 89.23% 89.23%
=======================================
Files 317 317
Lines 5557 5557
Branches 1375 1376 +1
=======================================
Hits 4959 4959
Misses 582 582
Partials 16 16 ☔ View full report in Codecov by Sentry. |
@bradenmacdonald the individual contribution CLA should be all set. Hopefully the folks at axim can confirm. |
FYI @feanil @gabor-boros - this is just a typo fix so not changing the intended specs of this security policy, but I want to give you a heads up before merging because it says "Changes to it should be vetted by" the security WG. |
80baeb1
to
46271a3
Compare
Thanks for the fix, @rediris ! |
This is a simple fix to the IFRAME_FEATURE_POLICY, wherein a comma was used instead of a semi-colon.
Refer to the following screencap of the console for the warnings: