feat: increased Course home font size #1600
Conversation
openedx-webhooks
added
the
open-source-contribution
|
Thanks for the pull request, @vladislavkeblysh! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Update the status of your PRYour PR is currently marked as a draft. After completing the steps above, update its status by clicking "Ready for Review", or removing "WIP" from the title, as appropriate. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1600 +/- ##
==========================================
+ Coverage 90.18% 90.32% +0.14%
==========================================
Files 339 338 -1
Lines 5810 5708 -102
Branches 1409 1384 -25
==========================================
- Hits 5240 5156 -84
+ Misses 552 533 -19
- Partials 18 19 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@vladislavkeblysh Thank you for this contribution! Since it seems to include user-facing changes, you'll likely need to get product approval for it. When you're ready please follow the instructions from the bot to get that process started. |
|
Hey @vladislavkeblysh, just checking in to see if you're still planning to continue working on this PR? |
vladislavkeblysh
force-pushed
the
keblysh/feat/course-home-font-size
branch
from
6bb5c60 to
acab6bb
Compare
|
@itsjeyd This PR ready to review |
vladislavkeblysh
requested review from
BilalQamar95,
KristinAoki and
Lunyachek
and removed request for
BilalQamar95
|
[inform]: Awaiting Product Review |
PKulkoRaccoonGang
added
the
create-sandbox
PKulkoRaccoonGang
added
create-sandbox
|
Some context after accessibility review: The LMS default body text is smaller than recommended for optimal readability. Adjusting the relevant CSS font-size to 1.2 ($font-size-base) rem appears to address the issue. |
|
|
||
| if (!welcomeMessageHtml) { | ||
| return null; | ||
| } | ||
|
|
||
| useEffect(() => { |
There was a problem hiding this comment.
[nit]: After discussions on the PWG, the answer was that this behavior of the buttons is a design decision. So, it seems to me that we should remove this useEffect and make sure that everything works correctly.
| const wideScreen = useWindowSize().width >= breakpoints.medium.minWidth; | ||
|
|
||
| return ( | ||
| <button |
There was a problem hiding this comment.
[open question]: should there be a component provided by Paragon? For example Paragon FormControl with type="radio"
| @@ -40,7 +43,10 @@ const CourseDates = ({ | |||
| /> | |||
| ))} | |||
| </ol> | |||
| <a className="font-weight-bold ml-4 pl-1 small" href={datesTabLink}> | |||
| <a | |||
There was a problem hiding this comment.
[open question]: should there be a component provided by Paragon? For example Paragon HyperLink
Description
Enlargement of the font-size in the Learning MFE.
Testing instructions