-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: replace edx.org brand dependency with openedx brand (#199) #200
Conversation
Thanks for the pull request, @snglth! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
@mphilbrick211 CLA was signed by my employed recently |
Thanks, @snglth! We'll get tests enabled for you. |
@snglth Can you provide a description of the purpose of this change? |
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #200 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 110 110
Lines 1079 1079
Branches 159 159
=========================================
Hits 1079 1079 ☔ View full report in Codecov by Sentry. |
Description provided |
@brian-smith-tcril this seems like a straight-forward and appropriate change. Could you have a look? |
Hi @openedx/content-aurora! Would someone be able to please merge this for us? Thanks! |
Hi @snglth! Some branch conflicts have popped up - would you mind taking a look? |
Hi @mphilbrick211. Conflicts fixed. |
Hi @openedx/content-aurora! Would someone be able to take a look at this? We had to fix branch conflicts, so would you mind enabling the tests to run again? |
@snglth 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
@edx/brand-edx.org package is not open source. @edx/brand-openedx is what is used by other MFEs by default.
Similar PR in gradebook