feat: remove CTA #347
feat: remove CTA #347
Conversation
openedx-webhooks
added
the
open-source-contribution
|
Thanks for the pull request, @asadali145! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently maintained by Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
asadali145
force-pushed
the
asad/remove-cta-hide-notifications-if-no-accounts-url
branch
from
730cebf
to
32e356a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #347 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 111 109 -2
Lines 1088 1085 -3
Branches 166 165 -1
=========================================
- Hits 1088 1085 -3 ☔ View full report in Codecov by Sentry. |
asadali145
force-pushed
the
asad/remove-cta-hide-notifications-if-no-accounts-url
branch
from
bf6cc32
to
4c884d6
Compare
|
@jansenk Would you be able to review this PR? |
asadali145
force-pushed
the
asad/remove-cta-hide-notifications-if-no-accounts-url
branch
from
4c884d6
to
056f661
Compare
asadali145
requested review from
brian-smith-tcril
and removed request for
arbrandes,
jansenk and
awais-ansari
|
@brian-smith-tcril Would you be able to review this PR? |
|
Looking at this PR raises a few questions for me:
My feeling is both the CTA and notification banner should just be removed completely. This would require going through the deprecation process. Would fully removing both the notification banner and the CTA solve the problem you're trying to solve with this PR? |
@brian-smith-tcril Yes, removing both solves our problem. We don't want to display the banners all the time. Thanks for reviewing the PR. Do you want me to start the depreciation process for these banners? |
That would be wonderful @asadali145! Thank you! |
|
@brian-smith-tcril I have created this DEPR ticket #360. Do you have any suggestions? [EDIT]: I also posted the question in the Open edX Slack to confirm the usage of the notifications banner. |
| @@ -6,7 +7,8 @@ import { PageBanner, Hyperlink } from '@openedx/paragon'; | |||
|
|
|||
| import messages from './messages'; | |||
|
|
|||
| export const NotificationsBanner = () => ( | |||
| // eslint-disable-next-line no-confusing-arrow | |||
There was a problem hiding this comment.
Please follow the eslint recommendations. Other than PR LGTM.
There was a problem hiding this comment.
I still think the best path forward for this would be to deprecate and fully remove both the CTA and notifications banner. If that isn't the direction we end up going I still do not approve of the way this is implemented.
- I don't believe using
ACCOUNT_SETTINGS_URLto determine if the notifications should appear or not is a good pattern. One other solution that comes to mind would be showing a different string without a link whenACCOUNT_SETTINGS_URLis not set.
Also, now that there seems to be more discussion around how we want to handle this, I believe it would be best to split this PR up. There should be one for removing the CTA, and one for modifying the notifications banner. That will allow the discussions to be targeted, and blockers for one won't get in the way of the other.
asadali145
force-pushed
the
asad/remove-cta-hide-notifications-if-no-accounts-url
branch
from
056f661
to
31629af
Compare
asadali145
changed the title
|
Thanks @brian-smith-tcril and @awais-ansari. I have updated this PR to remove the CTA. I'll create a new PR to update the notifications banner. I have updated the DEPR ticket as well. |
|
@brian-smith-tcril Just a reminder that this PR needs review along with #362 as discussed to create separate PRs. |
|
@brian-smith-tcril Thanks for approval. I do not have merge access. Please merge it if you can OR I can ask someone else to merge this. |
asadali145
force-pushed
the
asad/remove-cta-hide-notifications-if-no-accounts-url
branch
from
31629af
to
e932614
Compare
|
@brian-smith-tcril I have rebased this one as well. |
|
@asadali145 sorry I missed this! It looks like it needs another rebase. I've communicated my intention to merge, so as soon as it is rebased I'll hit the button. |
asadali145
force-pushed
the
asad/remove-cta-hide-notifications-if-no-accounts-url
branch
from
e932614
to
5d53592
Compare
|
@brian-smith-tcril This is rebased. You can merge. |
Relevant Tickets
#360
Description:
The CTA was added two years ago. It is enabled by default, and the notification is always visible. This PR removes the CTA. If we still need it, we can put it behind a flag.
Screen Shots:
Before:
After:
