-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: Remove support for Node 18 #352
base: master
Are you sure you want to change the base?
Conversation
Thanks for the pull request, @Anas12091101! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently maintained by Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #352 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 111 111
Lines 1082 1082
Branches 159 159
=========================================
Hits 1082 1082 ☔ View full report in Codecov by Sentry. |
@brian-smith-tcril - is this something you can help review? |
@brian-smith-tcril, could you please review this PR when you have a moment? |
The plan is to not drop Node 18 support until after Sumac is cut. The changes in this PR look perfect but I don't want to approve the PR and have someone accidentally merge it early. See the DEPR for more details on this plan: openedx/public-engineering#280 |
Thank you for the clarification👍 |
Complete the upgrade to Node 20 by removing the Node 18 CI check and going back to using .nvmrc as the source of truth for which version to use.
See the tracking issue for further information.