Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Add Node 20 to CI matrix #1069

Merged
merged 2 commits into from
Aug 22, 2024
Merged

Conversation

BilalQamar95
Copy link
Contributor

Description

As a first step in the upgrade to Node 20, add it to the CI matrix as a non-blocking test.

See the tracking issue for further information.

@BilalQamar95 BilalQamar95 self-assigned this Aug 21, 2024
@BilalQamar95 BilalQamar95 requested a review from a team as a code owner August 21, 2024 10:20
Copy link
Member

@MaxFrank13 MaxFrank13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like some snapshots are failing in CI. Otherwise, this looks good. Thanks for putting this together

@MaxFrank13 MaxFrank13 merged commit 714851c into master Aug 22, 2024
10 checks passed
@MaxFrank13 MaxFrank13 deleted the bilalqamar95/node20-upgrade-1 branch August 22, 2024 12:39
Copy link

codecov bot commented Aug 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.78%. Comparing base (b27300e) to head (f73df41).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1069   +/-   ##
=======================================
  Coverage   66.78%   66.78%           
=======================================
  Files          51       51           
  Lines         849      849           
  Branches      176      173    -3     
=======================================
  Hits          567      567           
  Misses        272      272           
  Partials       10       10           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants