Skip to content

Commit

Permalink
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: downgrading image-webpack-loader to fix linux arch bug
Browse files Browse the repository at this point in the history
There’s a documented issue in “imagemin-gifsicle” where a recent update (5.0.0) removed the binaries for linux distributions:

imagemin/gifsicle-bin#113

This causes it to explode in CI via our direct dependency on image-webpack-loader.  The 7.0.0 version of image-webpack-loader relies on version 5 of gifsicle.  If we downgrade back to 6.0.0, we get gifsicle 4.0.1 instead, which still has the binaries.
David Joy committed Dec 17, 2020

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
1 parent 631fde3 commit 4cfae09
Showing 2 changed files with 110 additions and 424 deletions.
532 changes: 109 additions & 423 deletions package-lock.json
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -56,7 +56,7 @@
"html-webpack-new-relic-plugin": "2.0.0",
"html-webpack-plugin": "4.5.0",
"identity-obj-proxy": "3.0.0",
"image-webpack-loader": "7.0.1",
"image-webpack-loader": "6.0.0",
"jest": "26.4.2",
"mini-css-extract-plugin": "0.12.0",
"new-relic-source-map-webpack-plugin": "1.2.0",

0 comments on commit 4cfae09

Please sign in to comment.