-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: added redux, selector and api cases #350
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sundasnoreen12
force-pushed
the
sundas/INF-878
branch
from
June 15, 2023 09:06
e6bf841
to
a865dbb
Compare
sundasnoreen12
changed the title
Sundas/inf 878
test: added redux, selector and api cases
Jun 15, 2023
sundasnoreen12
force-pushed
the
sundas/INF-878
branch
from
June 15, 2023 09:11
a865dbb
to
a9b8df4
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #350 +/- ##
===========================================
+ Coverage 43.33% 62.39% +19.05%
===========================================
Files 28 30 +2
Lines 570 585 +15
Branches 108 108
===========================================
+ Hits 247 365 +118
+ Misses 310 212 -98
+ Partials 13 8 -5
☔ View full report in Codecov by Sentry. |
sundasnoreen12
force-pushed
the
sundas/INF-878
branch
from
June 15, 2023 12:14
a9b8df4
to
24e0ebf
Compare
sundasnoreen12
force-pushed
the
sundas/INF-878
branch
from
June 15, 2023 12:27
24e0ebf
to
6efa310
Compare
sundasnoreen12
requested review from
awais-ansari,
ayesha-waris,
muhammadadeeltajamul and
asadazam93
June 15, 2023 12:36
awais-ansari
requested changes
Jun 16, 2023
sundasnoreen12
force-pushed
the
sundas/INF-878
branch
5 times, most recently
from
June 19, 2023 10:06
683a582
to
32f56f2
Compare
sundasnoreen12
force-pushed
the
sundas/INF-878
branch
from
June 19, 2023 10:33
32f56f2
to
4483a73
Compare
ayesha-waris
approved these changes
Jun 19, 2023
awais-ansari
requested changes
Jun 19, 2023
awais-ansari
approved these changes
Jun 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
INF-878
Description
Add unit tests for notifications redux, selectors and API
Add Factory for
a. Notifications Count
b. Notification List
API test cases
a. successfully get notification counts for different tabs
b. failed to get notification counts
c. denied to get notification counts
d. successfully get notifications
e. failed to get notifications
f. denied to get notifications
g. successfully marked all notifications as seen for selected app
h. failed to mark all notifications as seen for selected app
i. denied to mark all notifications as seen for selected app
j. successfully marked all notifications as read for selected app
k. failed to mark all notifications as read for selected app
l. denied to mark all notifications as read for selected app
m. successfully marked notification as read
n. failed to mark notification as read
o. denied to mark notification as read
Add test cases for following selectors:
a. should return notification status
b. should return notification tabs count
c. should return notification tabs
d. should return selected app notification ids
e. should return show notification tray status
f. should return notifications
g. should return notifications from Ids
h. should return selected app name
i. should return pagination data.
Redux test cases
a. Successfully loaded initial notification states in redux
b. Successfully loaded notifications list in the redux
c. Successfully loaded notification counts in the redux
d. Successfully loaded showNotificationTray status in the redux based on api
e. Successfully store the count, numPages, currentPage, and nextPage data in redux
f. Successfully updated the selected app name in redux
g. Successfully store notification ids in the selected app in apps
h. successfully marked all notifications as seen for selected app
i. successfully marked all notifications as read for selected app in the redux.
j. successfully marked notification as read in the redux.
Tested
Npm run test