Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: move paragon to peer dependency using @openedx scope #456

Merged

Conversation

brian-smith-tcril
Copy link
Contributor

Resolves #455
Part of openedx/axim-engineering#23 (comment)

BREAKING CHANGE: consuming applications must now provide paragon from the @openedx scope

@brian-smith-tcril brian-smith-tcril marked this pull request as ready for review January 12, 2024 19:56
Copy link

codecov bot commented Jan 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (36be99a) 66.96% compared to head (df0b9ae) 66.96%.
Report is 1 commits behind head on master.

❗ Current head df0b9ae differs from pull request most recent head 781cd48. Consider uploading reports for the commit 781cd48 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #456   +/-   ##
=======================================
  Coverage   66.96%   66.96%           
=======================================
  Files          25       25           
  Lines         339      339           
  Branches       78       78           
=======================================
  Hits          227      227           
  Misses        110      110           
  Partials        2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@arbrandes arbrandes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

BREAKING CHANGE: consuming applications must now provide `paragon` from the `@openedx` scope
@brian-smith-tcril brian-smith-tcril merged commit 54a879a into openedx:master Jan 16, 2024
5 checks passed
hinakhadim pushed a commit to edly-io/frontend-component-header that referenced this pull request Mar 7, 2024
…#456)

BREAKING CHANGE: consuming applications must now provide `paragon` from the `@openedx` scope
hinakhadim pushed a commit to edly-io/frontend-component-header that referenced this pull request Mar 7, 2024
…#456)

BREAKING CHANGE: consuming applications must now provide `paragon` from the `@openedx` scope
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Paragon installed as dependency instead of peer dependency
2 participants