Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: expose app entrypoint in webpack dev config for example app #531

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

adamstankiewicz
Copy link
Member

@adamstankiewicz adamstankiewicz commented Sep 10, 2024

Currently, running npm start on a fresh checkout results in a blank example app running on localhost:8080. This is a result of the recently merged ParagonWebpackPlugin changes in @openedx/frontend-build which assumes MFEs define an app entrypoint, as is the case in the default webpack.dev.config provided by @openedx/frontend-build, which this repo's example app overrides to be non-standard.

This PR defines the app entrypoint in webpack.dev.config.js.

Copy link

codecov bot commented Sep 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.60%. Comparing base (45e551e) to head (6df74d6).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #531   +/-   ##
=======================================
  Coverage   70.60%   70.60%           
=======================================
  Files          24       24           
  Lines         364      364           
  Branches       96       96           
=======================================
  Hits          257      257           
  Misses        105      105           
  Partials        2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant