fix: removing prequery optimizely code #413
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we have concluded the pre-query Optimizely experiment, we want to remove the outdated code.
Jira ticket
To properly test this ticket, you need to check out this branch and also
kiram15/ENT-9480
from frontend-app-learner-portal-enterprise. Then, you need to make sure that repository is pulling your local version of frontend-enterprise my creating a file calledmodule.config.js
with this content:Merge checklist:
frontend-app-learner-portal-enterprise
,frontend-app-admin-portal
, andfrontend-app-enterprise-public-catalog
). Will consumers safely be able to upgrade to this change without any breaking changes?BREAKING CHANGE
so the NPM package is released as such.Post merge:
chore(release): publish new versions
) that incremented versions in relevant package.json and CHANGELOG files, and created Git tags for those versions is onmaster
(Important: ensure the Git tags are for the correct commit SHA).Publish from package.json
Github Action workflow to publish these new package versions to NPM.master
branch.npm view <package_name> versions --json
).