Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: removing prequery optimizely code #413

Merged
merged 1 commit into from
Sep 16, 2024
Merged

fix: removing prequery optimizely code #413

merged 1 commit into from
Sep 16, 2024

Conversation

kiram15
Copy link
Contributor

@kiram15 kiram15 commented Sep 11, 2024

Since we have concluded the pre-query Optimizely experiment, we want to remove the outdated code.
Jira ticket

To properly test this ticket, you need to check out this branch and also kiram15/ENT-9480 from frontend-app-learner-portal-enterprise. Then, you need to make sure that repository is pulling your local version of frontend-enterprise my creating a file called module.config.js with this content:

module.exports = {
localModules: [
{
moduleName: '@edx/frontend-enterprise-catalog-search',
dir: '../frontend-enterprise/packages/catalog-search',
dist: 'src',
},
{
moduleName: '@edx/frontend-enterprise-utils',
dir: '../frontend-enterprise/packages/utils',
dist: 'src',
}
],
};

Merge checklist:

  • Evaluate how your changes will impact existing consumers (e.g., frontend-app-learner-portal-enterprise, frontend-app-admin-portal, and frontend-app-enterprise-public-catalog). Will consumers safely be able to upgrade to this change without any breaking changes?
  • Ensure your commit message follows the semantic-release conventional commit message format. If your changes include a breaking change, ensure your commit message is explicitly marked as a BREAKING CHANGE so the NPM package is released as such.
  • Once CI is passing, verify the package versions that Lerna will increment to in the Github Action CI workflow logs.
    • Note: This may be found in the "Preview Updated Versions (dry run)" step in the Github Action CI workflow logs.

Post merge:

  • Follow the release steps in the README documentation. Verify Lerna's release commit (e.g., chore(release): publish new versions) that incremented versions in relevant package.json and CHANGELOG files, and created Git tags for those versions is on master (Important: ensure the Git tags are for the correct commit SHA).
  • Run the Publish from package.json Github Action workflow to publish these new package versions to NPM.
    • This may be triggered by clicking the "Run workflow" option for the master branch.
  • Verify the new package versions were published to NPM (i.e., npm view <package_name> versions --json).
    • Note: There may be a slight delay between when the workflow finished and when NPM reports the package version as being published. If it doesn't appear right away in the above command, try again in a few minutes.

Copy link
Contributor

@katrinan029 katrinan029 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kiram15 kiram15 merged commit 68d3497 into master Sep 16, 2024
5 checks passed
@kiram15 kiram15 deleted the kiram15/ENT-9480 branch September 16, 2024 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants