Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Remove support for Node 18 #735

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

BilalQamar95
Copy link
Contributor

Description

Completed upgrade to Node 20 by removing the Node 18 CI check and using .nvmrc for version to use.

See the tracking issue for further information.

@BilalQamar95 BilalQamar95 self-assigned this Sep 20, 2024
@BilalQamar95 BilalQamar95 mentioned this pull request Sep 20, 2024
Copy link

codecov bot commented Sep 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.41%. Comparing base (dd36b46) to head (2b80a63).
Report is 8 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #735   +/-   ##
=======================================
  Coverage   83.41%   83.41%           
=======================================
  Files          40       40           
  Lines        1073     1073           
  Branches      197      197           
=======================================
  Hits          895      895           
  Misses        166      166           
  Partials       12       12           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brian-smith-tcril brian-smith-tcril merged commit 07ee86c into master Oct 31, 2024
6 checks passed
@brian-smith-tcril brian-smith-tcril deleted the bilalqamar95/node20-upgrade-3 branch October 31, 2024 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants