Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add fields related to custom expiration messaging to CustomerAg… #713

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

jajjibhai008
Copy link
Contributor

@jajjibhai008 jajjibhai008 commented Sep 19, 2024

Description

JIRA -> ENT-9510

image

Django Admin:

image

Description

Description of changes made

Link to the associated ticket: https://openedx.atlassian.net/browse/ENT-XXXX

Testing considerations

  • Include instructions for any required manual tests, and any manual testing that has
    already been performed.
  • Include unit and a11y tests as appropriate
  • Consider performance issues.
  • Check that Database migrations are backwards-compatible

Post-review

Squash commits into discrete sets of changes

@jajjibhai008 jajjibhai008 force-pushed the eahmadjaved/ENT-9510 branch 4 times, most recently from 81de296 to b8b2824 Compare September 25, 2024 10:49
Copy link
Contributor

@iloveagent57 iloveagent57 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you'll definitely want a longer max length for expired_subscription_modal_messaging, maybe some other fields.

license_manager/apps/subscriptions/models.py Outdated Show resolved Hide resolved
license_manager/apps/subscriptions/models.py Outdated Show resolved Hide resolved
license_manager/apps/subscriptions/models.py Show resolved Hide resolved
@jajjibhai008 jajjibhai008 merged commit efdfe54 into master Sep 30, 2024
5 checks passed
@jajjibhai008 jajjibhai008 deleted the eahmadjaved/ENT-9510 branch September 30, 2024 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants