Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme/script improvements #231

Merged

Conversation

rnr
Copy link
Contributor

@rnr rnr commented Jan 12, 2024

Improvements for the whitelabel.py theme script

  • Added ability to specify which other targets in the project should receive the new development team ID (other than 'OpenEdX' by default) - this helps avoid build errors when deploying to a device in Xcode
  • Added ability to override font in iOS app
  • Updated documentation to reflect the above changes

Custom edX theme example

Clone https://github.com/edx/edx-mobile-config into the OpenEdX root folder and switch to the anton/openedX-theming branch.

From the OpenEdX root folder, run the script as:

python config_script/whitelabel.py --config-file=edx-mobile-config/openEdXAssets/whitelabel.yaml -v

Install on your simulator or device
All possible config parameters are described in this documentation

@rnr rnr linked an issue Jan 12, 2024 that may be closed by this pull request
forgotvas
forgotvas previously approved these changes Jan 12, 2024
shafqat-muneer
shafqat-muneer previously approved these changes Jan 15, 2024
Copy link
Contributor

@shafqat-muneer shafqat-muneer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just added one formatted suggestion. Please have a look.

Script is working successfully: 👏

Screenshot 2024-01-15 at 6 17 52 PM

Comment on lines 85 to 86
- bold
For this function, the configuration must contain the following parameters:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the preview, there is no line break, and the text appears as follows:

bold For this function, the configuration must contain the following parameters:

updated documentation file
@rnr rnr force-pushed the theme/script_improvements- branch from 8e394a5 to ad6f9f8 Compare January 15, 2024 18:19
@volodymyr-chekyrta volodymyr-chekyrta merged commit f8e1e94 into openedx:develop Jan 16, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[iOS] Add fonts to the theme script
4 participants