-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: [FC-0047] Relative Dates #505
feat: [FC-0047] Relative Dates #505
Conversation
Thanks for the pull request, @IvanStepanok! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently maintained by Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
HI @IvanStepanok, this looks almost all good from the design side. For upcoming dates within the There are a lot of edge cases here, so I did my best to document them in the Figma file below the Dates section: https://www.figma.com/design/iZ56YMjbRMShCCDxqrqRrR/Open-edX-Mobile-App-All-Screens-v2.2?node-id=6703-32751&t=vxtbWParuRUmfgkZ-4 Here are the cases documented there for reference: Sections & date formats (items appear once, in the first case they meet)
|
Hi @IvanStepanok, once the date handling has been updated to match the comment above/what @PavloNetrebchuk described on the Android version, I think this is all clear from the design side for now. In the future, I think it's worth coming back to this and reconsidering how we approach dates/examining some edge cases, so I've created a new roadmap issue (#513) to track that future work. |
Dashboard/Dashboard/Presentation/Elements/PrimaryCardView.swift
Outdated
Show resolved
Hide resolved
Discovery/Discovery/Presentation/NativeDiscovery/DiscoveryViewModel.swift
Show resolved
Hide resolved
Discussion/Discussion/Presentation/Comments/Responses/ResponsesView.swift
Show resolved
Hide resolved
Discussion/Discussion/Presentation/Comments/Responses/ResponsesView.swift
Show resolved
Hide resolved
Discussion/Discussion/Presentation/Comments/Responses/ResponsesView.swift
Show resolved
Hide resolved
Discussion/DiscussionTests/Presentation/Comment/Base/BaseResponsesViewModelTests.swift
Outdated
Show resolved
Hide resolved
Discussion/DiscussionTests/Presentation/Posts/PostViewModelTests.swift
Outdated
Show resolved
Hide resolved
@salman2013 Thanks for your review; all feedback has been addressed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good to me.
@IvanStepanok 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
New Feature: Relative Date Display
The useRelativeDates functionality has been added to improve the readability of dates within the application. When this feature is enabled (default setting), dates within the range of -7 to +7 days from the current date will be displayed in a relative format (e.g., "just now," "2 days ago"). Dates outside this range will continue to be displayed in the traditional format. This setting can be toggled in the calendar synchronization settings.
Quick Demo
Screen.Recording.2024-07-19.at.11.26.47.mov
Environment for testing: