-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: providing basic quince support #63
Conversation
Thanks for the pull request, @jfavellar90! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @jfavellar90, we tested this PR.
I have tested the following points with the current deployment. I have tested this by verifying the config files generated by Tutor.
- The ingress service file I checked under
instances/example/env/k8s/services.yml
and it is following the correct template pattern, I checked the deployment as well
The yaml file was correctly generated and applied.
- The openedx-common-settings was tested by looking for
ELASTIC_SEARCH_CONFIG
in instances/example/env/apps/openedx/settings/cms/production.py and instances/example/env/apps/openedx/settings/lms/production.py. This was perfectly present in the file as:
ELASTIC_SEARCH_INDEX_PREFIX = "example-"
ELASTIC_SEARCH_CONFIG = [{
"use_ssl": True,
"host": "harmony-search-cluster.harmony.svc.cluster.local",
"verify_certs": False,
"port": 9200,
"http_auth": "example:password"
}]
I also tested this on the shell and got the same config.
9b074a0
to
4500947
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on @farhaanbukhsh's review, I think this PR can be approved.
@jfavellar90 Feel free to merge this PR if there is nothing else you wanted to add.
FTR: Merging as it is a blocker and already got approved. |
@jfavellar90 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
This PR aims to provide Harmony plugin support for the Quince OpenedX release.