-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: extend ingress hosts #74
Conversation
Signed-off-by: Gabor Boros <[email protected]>
Thanks for the pull request, @gabor-boros! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
2 similar comments
Thanks for the pull request, @gabor-boros! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
Thanks for the pull request, @gabor-boros! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
tutor-contrib-harmony-plugin/tutor_k8s_harmony_plugin/patches/k8s-services
Outdated
Show resolved
Hide resolved
Signed-off-by: Gabor Boros <[email protected]>
@gabor-boros, what are your thoughts about splitting the ingress objects per service? One issue with having all the services in a single object is that if you were to make use of the |
@MoisesGSalas Sure! I'm going to refactor it today. This is a great idea. |
bb21982
to
f5b8c17
Compare
Signed-off-by: Gabor Boros <[email protected]>
f5b8c17
to
13ea575
Compare
Signed-off-by: Gabor Boros <[email protected]>
tutor-contrib-harmony-plugin/tutor_k8s_harmony_plugin/patches/k8s-services
Show resolved
Hide resolved
Signed-off-by: Gabor Boros <[email protected]>
@gabor-boros 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
Description
This PR adds the Discovery and Ecommerce hosts to the ingress configuration if the corresponding variables are defined.
Testing