Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: extend ingress hosts #74

Merged
merged 5 commits into from
May 28, 2024
Merged

refactor: extend ingress hosts #74

merged 5 commits into from
May 28, 2024

Conversation

gabor-boros
Copy link
Contributor

@gabor-boros gabor-boros commented May 6, 2024

Description

This PR adds the Discovery and Ecommerce hosts to the ingress configuration if the corresponding variables are defined.

Testing

  • Deploy instance
  • Setup discovery
  • Setup ecommerce (optional as both services are configured the same way)
  • Check that discovery loads

@gabor-boros gabor-boros added open-source-contribution PR author is not from Axim or 2U waiting for eng review PR is ready for review. Review and merge it, or suggest changes. labels May 6, 2024
@gabor-boros gabor-boros self-assigned this May 6, 2024
@openedx-webhooks
Copy link

Thanks for the pull request, @gabor-boros! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

2 similar comments
@openedx-webhooks
Copy link

Thanks for the pull request, @gabor-boros! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@openedx-webhooks
Copy link

Thanks for the pull request, @gabor-boros! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@MoisesGSalas
Copy link
Contributor

@gabor-boros, what are your thoughts about splitting the ingress objects per service?

One issue with having all the services in a single object is that if you were to make use of the server-snippet annotation it would apply to all the hosts.

@gabor-boros
Copy link
Contributor Author

@MoisesGSalas Sure! I'm going to refactor it today. This is a great idea.

@gabor-boros gabor-boros merged commit 9054a5f into main May 28, 2024
2 checks passed
@gabor-boros gabor-boros deleted the gabor/ingress-refactor branch May 28, 2024 18:16
@openedx-webhooks
Copy link

@gabor-boros 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U waiting for eng review PR is ready for review. Review and merge it, or suggest changes.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants