Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bypassing OCI registries for Harmony chart release #55

Merged
merged 1 commit into from
Jan 4, 2024

Conversation

jfavellar90
Copy link
Contributor

@jfavellar90 jfavellar90 commented Dec 19, 2023

This PR aims to fix an issue during the Harmony chart release (check this failed release ). The helm repo subcommands are not supported for OCI registries. See https://helm.sh/docs/topics/registries/ to get more details.

It was tested in this fork where the release was generated with success

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Dec 19, 2023
@openedx-webhooks
Copy link

Thanks for the pull request, @jfavellar90! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@jfavellar90
Copy link
Contributor Author

jfavellar90 commented Dec 19, 2023

I think it's worth mentioning that the Helm repositories are added to the workflow because this issue.

@gabor-boros gabor-boros added the waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. label Dec 29, 2023
Copy link
Contributor

@MoisesGSalas MoisesGSalas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jfavellar90 jfavellar90 removed the waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. label Jan 4, 2024
@jfavellar90 jfavellar90 merged commit 8f47569 into main Jan 4, 2024
2 checks passed
@openedx-webhooks
Copy link

@jfavellar90 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@jfavellar90 jfavellar90 deleted the Jhony/fix_helm_release branch January 4, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants