Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add ClickHouse operator sub-chart #90

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: add ClickHouse operator sub-chart #90

wants to merge 2 commits into from

Conversation

Ian2012
Copy link
Contributor

@Ian2012 Ian2012 commented Nov 5, 2024 •
edited
Loading

Description

This PR adds the Altinity ClickHouse Operator helm chart to Harmony

Closes: #45

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Nov 5, 2024
@openedx-webhooks
Copy link

openedx-webhooks commented Nov 5, 2024 •
edited
Loading

Thanks for the pull request, @Ian2012!

What's next?

Please work through the following steps to get your changes ready for engineering review:

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @openedx/openedx-k8s-harmony-maintainers. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@Ian2012 Ian2012 marked this pull request as draft November 5, 2024 16:49
@Ian2012 Ian2012 marked this pull request as ready for review November 5, 2024 17:44
bmtcril
bmtcril reviewed Nov 5, 2024
View reviewed changes
README.md
Altinity ClickHouse Operator and follow the templates available on `charts/examples/clickhouse` to setup a ClickHouseKeeper
quorum (needed for replication) and a ClickHouse cluster based on your needs.

Once your cluster is created and working on Kubernetes, you need to update your installation settings:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be clear, these are settings that are defined in tutor-contrib-aspects, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

bmtcril
bmtcril reviewed Nov 5, 2024
View reviewed changes
README.md
CLICKHOUSE_CLUSTER_NAME: openedx-demo
# Set the first ClickHouse node as the DDL node.
CLICKHOUSE_CLUSTER_DDL_NODE_HOST: chi-clickhouse-{{CLICKHOUSE_CLUSTER_NAME}}-0-0.{{namespace}}
CLICKHOUSE_HOST: clickhouse-clickhouse.{{namespace}}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this correct?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this is what I've tested so far.

@Ian2012 Ian2012 mentioned this pull request Nov 5, 2024
Open
@Ian2012
Copy link
Contributor Author

Ian2012 commented Nov 5, 2024 •
edited
Loading

Here is a PR to add integration testing for ClickHouse based on #80: eduNEXT#14

See output: https://github.com/eduNEXT/openedx-k8s-harmony/actions/runs/11692961358/job/32563443990?pr=14

@Ian2012 Ian2012 mentioned this pull request Nov 15, 2024
Open
@bradenmacdonald
Copy link
Contributor

@Ian2012 I don't think I know enough to review this PR for you.

@mphilbrick211 mphilbrick211 requested a review from a team November 21, 2024 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmtcril bmtcril Awaiting requested review from bmtcril

@MoisesGSalas MoisesGSalas Awaiting requested review from MoisesGSalas

@jfavellar90 jfavellar90 Awaiting requested review from jfavellar90

@gabor-boros gabor-boros Awaiting requested review from gabor-boros

@bradenmacdonald bradenmacdonald Awaiting requested review from bradenmacdonald

Assignees
No one assigned
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Contributions
Status: In Eng Review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Hosting of Clickhouse for Aspects
4 participants
@Ian2012 @openedx-webhooks @bradenmacdonald @bmtcril